Skip to content

Conversation

@jepett0
Copy link
Contributor

@jepett0 jepett0 commented Jul 8, 2024

Ticket
PR into main

Motivation

The test was failing in the new stable-24-3, because of the different default value of the FeatureFlag.EnableLocalDBBtreeIndex.

Fix

Make the test independent of the FeatureFlags.EnableLocalDBBtreeIndex.

- make it independent of the FeatureFlags.EnableLocalDBBtreeIndex
@github-actions
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 20:16:17 UTC Pre-commit check for bf0d495 has started.
2024-07-08 20:18:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 20:19:54 UTC Build successful.
2024-07-08 20:20:09 UTC Tests are running...
🟢 2024-07-08 20:25:00 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77 75 0 0 2 0

🟢 2024-07-08 20:25:22 UTC ydbd size 5.2 GiB changed* by -96 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 44a1cd0 merge: bf0d495 diff diff %
ydbd size 5 615 664 240 Bytes 5 615 664 144 Bytes -96 Bytes -0.000%
ydbd stripped size 1 211 071 912 Bytes 1 211 071 848 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 20:19:14 UTC Pre-commit check for bf0d495 has started.
2024-07-08 20:21:40 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 20:23:05 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 20:21:28 UTC Pre-commit check for bf0d495 has started.
2024-07-08 20:23:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 20:25:56 UTC Build successful.
2024-07-08 20:26:06 UTC Tests are running...
🟢 2024-07-08 20:30:43 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78 76 0 0 2 0

🟢 2024-07-08 20:30:58 UTC ydbd size 8.1 GiB changed* by -32 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 44a1cd0 merge: bf0d495 diff diff %
ydbd size 8 725 589 248 Bytes 8 725 589 216 Bytes -32 Bytes -0.000%
ydbd stripped size 477 140 648 Bytes 477 140 648 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 marked this pull request as ready for review July 9, 2024 06:33
@jepett0 jepett0 requested a review from a team as a code owner July 9, 2024 06:33
@jepett0 jepett0 requested a review from ijon July 9, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants