Skip to content

fix splitting to prevent empty batches #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanmorozov333 merged 2 commits into from
Jul 13, 2024
Merged

fix splitting to prevent empty batches #6632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d20814
fix splitting to prevent empty batches
ivanmorozov333 Jul 12, 2024
afeae69
correction
ivanmorozov333 Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions ydb/core/formats/arrow/arrow_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,24 +892,33 @@ std::shared_ptr<arrow::RecordBatch> MergeColumns(const std::vector<std::shared_p
}

std::vector<std::shared_ptr<arrow::RecordBatch>> SliceToRecordBatches(const std::shared_ptr<arrow::Table>& t) {
std::set<ui32> splitPositions;
const ui32 numRows = t->num_rows();
for (auto&& i : t->columns()) {
ui32 pos = 0;
for (auto&& arr : i->chunks()) {
splitPositions.emplace(pos);
pos += arr->length();
if (!t->num_rows()) {
return {};
}
std::vector<ui32> positions;
{
for (auto&& i : t->columns()) {
ui32 pos = 0;
for (auto&& arr : i->chunks()) {
positions.emplace_back(pos);
pos += arr->length();
}
AFL_VERIFY(pos == t->num_rows());
}
AFL_VERIFY(pos == t->num_rows());
positions.emplace_back(t->num_rows());
}
std::sort(positions.begin(), positions.end());
positions.erase(std::unique(positions.begin(), positions.end()), positions.end());

std::vector<std::vector<std::shared_ptr<arrow::Array>>> slicedData;
slicedData.resize(splitPositions.size());
std::vector<ui32> positions(splitPositions.begin(), splitPositions.end());
for (auto&& i : t->columns()) {
for (ui32 idx = 0; idx < positions.size(); ++idx) {
auto slice = i->Slice(positions[idx], ((idx + 1 == positions.size()) ? numRows : positions[idx + 1]) - positions[idx]);
AFL_VERIFY(slice->num_chunks() == 1);
slicedData[idx].emplace_back(slice->chunks().front());
slicedData.resize(positions.size() - 1);
{
for (auto&& i : t->columns()) {
for (ui32 idx = 0; idx + 1 < positions.size(); ++idx) {
auto slice = i->Slice(positions[idx], positions[idx + 1] - positions[idx]);
AFL_VERIFY(slice->num_chunks() == 1);
slicedData[idx].emplace_back(slice->chunks().front());
}
}
}
std::vector<std::shared_ptr<arrow::RecordBatch>> result;
Expand Down