Skip to content

[dq] Separate setting SplitStageOnDqReplicate (YQL-17382) #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvu1024 merged 1 commit into from
Dec 22, 2023
Merged

[dq] Separate setting SplitStageOnDqReplicate (YQL-17382) #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ydb/library/yql/cfg/tests/gateways.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ Dq {
Name: "UseWideChannels"
Value: "true"
}

DefaultSettings {
Name: "SplitStageOnDqReplicate"
Value: "true"
}
}

Fs {
Expand Down
8 changes: 8 additions & 0 deletions ydb/library/yql/providers/dq/common/yql_dq_settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,18 @@ TDqConfiguration::TDqConfiguration() {
.ValueSetter([this](const TString&, TDqSettings::ESpillingEngine value) {
SpillingEngine = value;
if (value != TDqSettings::ESpillingEngine::Disable) {
SplitStageOnDqReplicate = false;
EnableDqReplicate = true;
}
});
REGISTER_SETTING(*this, DisableLLVMForBlockStages);
REGISTER_SETTING(*this, SplitStageOnDqReplicate)
.ValueSetter([this](const TString&, bool value) {
SplitStageOnDqReplicate = value;
if (!value) {
EnableDqReplicate = true;
}
});
}

} // namespace NYql
1 change: 1 addition & 0 deletions ydb/library/yql/providers/dq/common/yql_dq_settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ struct TDqSettings {
NCommon::TConfSetting<bool, false> UseBlockReader;
NCommon::TConfSetting<ESpillingEngine, false> SpillingEngine;
NCommon::TConfSetting<bool, false> DisableLLVMForBlockStages;
NCommon::TConfSetting<bool, false> SplitStageOnDqReplicate;

// This options will be passed to executor_actor and worker_actor
template <typename TProtoConfig>
Expand Down
2 changes: 1 addition & 1 deletion ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ struct TDqsPipelineConfigurator : public IPipelineConfigurator {
}
pipeline->Add(
NDq::CreateDqBuildPhyStagesTransformer(
State_->Settings->SpillingEngine.Get().GetOrElse(TDqSettings::TDefault::SpillingEngine) != TDqSettings::ESpillingEngine::Disable,
!State_->Settings->SplitStageOnDqReplicate.Get().GetOrElse(true),
*pipeline->GetTypeAnnotationContext(), mode
),
"BuildPhy");
Expand Down