Fix flaky KqpOlapScheme.DropTable #6795
Conversation
| UNIT_ASSERT_C(testHelper.GetKikimr().GetTestClient().TabletExistsInHive(&testHelper.GetRuntime(), tablet), ToString(tablet) + " not alive"); | ||
| } | ||
| testHelper.DropTable("/Root/ColumnTableTest"); | ||
| for (auto tablet: tabletIds) { |
There was a problem hiding this comment.
а можешь как-то лаконичнее и переиспользуемее написать?
There was a problem hiding this comment.
вынес ожидание в testHelper. я не нашёл других подходящих функций
|
⚪
|
|
⚪
|
|
|
||
| void TTestHelper::WaitTabletDeletionInHive(ui64 tabletId, TDuration duration) { | ||
| auto deadline = TInstant::Now() + duration; | ||
| while (GetKikimr().GetTestClient().TabletExistsInHive(&GetRuntime(), tabletId) && deadline >= TInstant::Now()) { |
There was a problem hiding this comment.
minor: на мой вкус было бы лучше ... && TInstant::Now() < deadline
There was a problem hiding this comment.
согласен, поправил
|
⚪
|
|
⚪
|
3 participants
Messages TEvDeleteTablet and TEvRequestHiveInfo are sent from unit test to a hive throught different pipes, so they can be handled out of order. Because of that, a tablet may be recognised as alive shortly after DropTable is finished.