Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inferred types for csv files are now optional #7358

Conversation

evanevanevanevannnn
Copy link
Collaborator

@evanevanevanevannnn evanevanevanevannnn commented Aug 1, 2024

Changelog entry

now inferring column datatypes from .csv file produces optional (nullable) types

Changelog category

  • Bugfix

Additional info

Before that change trying to read a .csv file with with_infer='true' param lead to an error if there were any null values

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 14:18:57 UTC Pre-commit check for d87d95e has started.
2024-08-01 14:21:58 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 16:32:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14020 12669 0 4 1333 14

2024-08-01 16:34:36 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 16:43:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 10 0 2 0 9

2024-08-01 16:44:34 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-01 16:53:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 2 0 2 0 8

🟢 2024-08-01 16:54:12 UTC Build successful.
🟢 2024-08-01 16:54:48 UTC ydbd size 8.1 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b08c9a5 merge: d87d95e diff diff %
ydbd size 8 672 679 560 Bytes 8 672 682 320 Bytes +2.7 KiB +0.000%
ydbd stripped size 472 081 000 Bytes 472 081 128 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Aug 1, 2024
dorooleg
dorooleg previously approved these changes Aug 1, 2024
GrigoriyPA
GrigoriyPA previously approved these changes Aug 1, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 14:03:24 UTC Pre-commit check for d87d95e has started.
2024-08-01 14:06:18 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 14:12:10 UTC Build successful.

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 22:52:54 UTC Pre-commit check for c5548ae has started.
2024-08-01 22:55:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 23:05:31 UTC Build successful.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 22:53:03 UTC Pre-commit check for c5548ae has started.
2024-08-01 22:56:25 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 00:51:46 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9719 9678 0 7 22 12

🟢 2024-08-02 00:53:12 UTC Build successful.
🟢 2024-08-02 00:53:39 UTC ydbd size 5.4 GiB changed* by +2.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0c6ab2 merge: c5548ae diff diff %
ydbd size 5 842 854 176 Bytes 5 842 856 352 Bytes +2.1 KiB +0.000%
ydbd stripped size 1 464 161 104 Bytes 1 464 161 488 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 23:15:44 UTC Pre-commit check for c5548ae has started.
2024-08-01 23:18:40 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 00:48:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14021 12668 0 4 1333 16

2024-08-02 00:50:00 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 00:58:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 8 0 2 0 12

2024-08-02 01:00:11 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-02 01:08:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 1 0 2 0 12

🟢 2024-08-02 01:09:19 UTC Build successful.
🟢 2024-08-02 01:09:56 UTC ydbd size 8.1 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0c6ab2 merge: c5548ae diff diff %
ydbd size 8 674 766 744 Bytes 8 674 769 504 Bytes +2.7 KiB +0.000%
ydbd stripped size 472 123 112 Bytes 472 123 240 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@evanevanevanevannnn evanevanevanevannnn dismissed stale reviews from GrigoriyPA and dorooleg via c32a7b9 August 2, 2024 07:23
Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 07:24:53 UTC Pre-commit check for d8f70da has started.
2024-08-02 07:27:54 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-02 07:37:36 UTC Build successful.

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 07:26:38 UTC Pre-commit check for d8f70da has started.
2024-08-02 07:29:33 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 09:35:06 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9701 9626 0 30 26 19

🟢 2024-08-02 09:36:12 UTC Build successful.
🟢 2024-08-02 09:36:43 UTC ydbd size 5.4 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 153df90 merge: d8f70da diff diff %
ydbd size 5 843 615 264 Bytes 5 843 617 488 Bytes +2.2 KiB +0.000%
ydbd stripped size 1 464 332 496 Bytes 1 464 332 944 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 07:27:33 UTC Pre-commit check for d8f70da has started.
2024-08-02 07:30:26 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 09:02:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14023 12665 0 3 1335 20

2024-08-02 09:03:55 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 09:15:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 9 0 2 4 12

2024-08-02 09:16:21 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 09:23:13 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 6 0 0 0 12

🟢 2024-08-02 09:24:24 UTC Build successful.
🟢 2024-08-02 09:25:02 UTC ydbd size 8.1 GiB changed* by -1.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6416406 merge: d8f70da diff diff %
ydbd size 8 676 085 112 Bytes 8 676 083 144 Bytes -1.9 KiB -0.000%
ydbd stripped size 472 182 088 Bytes 472 182 152 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit ca41215 into ydb-platform:main Aug 2, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants