Skip to content

hotfix for hotkeys #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adameat merged 1 commit into from
Aug 2, 2024
Merged

hotfix for hotkeys #7425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions ydb/core/viewer/json_hotkeys.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,23 +85,25 @@ class TJsonHotkeys : public TViewerPipeClient<TJsonHotkeys> {
const auto& pathDescription = pbRecord.GetPathDescription();
const auto& partitions = pathDescription.GetTablePartitions();
const auto& metrics = pathDescription.GetTablePartitionMetrics();
TVector<std::pair<ui64, int>> tabletsOrder;
if (!metrics.empty()) {
TVector<std::pair<ui64, int>> tabletsOrder;

for (int i = 0; i < metrics.size(); ++i) {
tabletsOrder.emplace_back(metrics.Get(i).GetCPU(), i);
}

Sort(tabletsOrder, std::greater<std::pair<ui64, int>>());
ui32 tablets = (ui32) std::max(1, (int) std::ceil(PollingFactor * tabletsOrder.size()));
for (int i = 0; i < metrics.size(); ++i) {
tabletsOrder.emplace_back(metrics.Get(i).GetCPU(), i);
}

for (ui32 i = 0; i < tablets; ++i) {
THolder<TEvDataShard::TEvGetDataHistogramRequest> request = MakeHolder<TEvDataShard::TEvGetDataHistogramRequest>();
if (EnableSampling) {
request->Record.SetCollectKeySampleMs(30000); // 30 sec
Sort(tabletsOrder, std::greater<std::pair<ui64, int>>());
ui32 tablets = (ui32) std::max(1, (int) std::ceil(PollingFactor * tabletsOrder.size()));

for (ui32 i = 0; i < tablets; ++i) {
THolder<TEvDataShard::TEvGetDataHistogramRequest> request = MakeHolder<TEvDataShard::TEvGetDataHistogramRequest>();
if (EnableSampling) {
request->Record.SetCollectKeySampleMs(30000); // 30 sec
}
request->Record.SetActualData(true);
ui64 datashardId = partitions.Get(tabletsOrder[i].second).GetDatashardId();
SendRequestToPipe(ConnectTabletPipe(datashardId), request.Release());
}
request->Record.SetActualData(true);
ui64 datashardId = partitions.Get(tabletsOrder[i].second).GetDatashardId();
SendRequestToPipe(ConnectTabletPipe(datashardId), request.Release());
}
}

Expand Down