Yq 3428 fix #7450
Yq 3428 fix #7450
Conversation
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -307,15 +307,17 @@ struct TObjectStorageExternalSource : public IExternalSource { | |||
| structuredTokenBuilder.SetNoAuth(); | |||
| } | |||
|
|
|||
| const TString effectiveFilePattern = meta->TableLocation ? meta->TableLocation : "*"; | |||
There was a problem hiding this comment.
а разве возможно чтобы TableLocation был пустым?
There was a problem hiding this comment.
да, мы когда указывает в запросе директорию, у нас meta->DataSourceLocation это пусть к файлу (в данном случае путь директории), а meta->TableLocation это имя файла (или wildCardExpr/regExpr)
вот здесь при чтении файлов так же делается, а при сборке метаданных (в том числе схемы таблицы при выводе типов) почему-то так не сделали
There was a problem hiding this comment.
DataSourceLocation это путь к data source
А TableLocation это путь к таблице/директории/файлу. Почему он пустой если указали путь к директории?
Разве возможно написать?:
select * from connection.``
There was a problem hiding this comment.
можно написать
select * from connection.'/'
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
fix for https://st.yandex-team.ru/YQ-3428
now treating directory as
directory/*when trying to load metadata in csv inferring modeChangelog category