Skip to content

fix segfault in deserializer stream usage #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivanmorozov333 merged 3 commits into from
Aug 8, 2024
Merged

fix segfault in deserializer stream usage #7542

ivanmorozov333 merged 3 commits into from
Aug 8, 2024

Conversation

@ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented Aug 7, 2024

  • Bugfix

@github-actions github-actions bot added the bugfix label Aug 7, 2024
@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:02:48 UTC Pre-commit check for b445b5c has started.
⚪ 2024-08-07 15:09:52 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-07 15:15:04 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:03:36 UTC Pre-commit check for b445b5c has started.
⚪ 2024-08-07 15:09:37 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-07 15:29:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:04:05 UTC Pre-commit check for b445b5c has started.
⚪ 2024-08-07 15:09:43 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-07 15:28:49 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the fix_segfault_in_deserializer_stream branch from 9bedfa6 to b42f16f Compare August 7, 2024 15:28
@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:33:09 UTC Pre-commit check for 7333ec7 has started.
⚫ 2024-08-07 15:35:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:33:11 UTC Pre-commit check for 7333ec7 has started.
⚫ 2024-08-07 15:35:53 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:33:51 UTC Pre-commit check for 7333ec7 has started.
⚫ 2024-08-07 15:34:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:37:12 UTC Pre-commit check for 684f333 has started.
⚪ 2024-08-07 15:40:04 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-07 15:43:06 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:39:14 UTC Pre-commit check for 684f333 has started.
⚪ 2024-08-07 15:43:22 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-07 15:46:39 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:39:33 UTC Pre-commit check for 684f333 has started.
⚪ 2024-08-07 15:43:57 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-07 15:47:48 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:55:14 UTC Pre-commit check for 99c50fa has started.
⚪ 2024-08-07 15:58:15 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-07 16:05:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:56:11 UTC Pre-commit check for 99c50fa has started.
⚪ 2024-08-07 15:59:13 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-07 18:04:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9838 9789 0 11 25 13

🟢 2024-08-07 18:06:07 UTC Build successful.
🟢 2024-08-07 18:06:35 UTC ydbd size 5.4 GiB changed* by -25.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1593a2d merge: 99c50fa diff diff %
ydbd size 5 832 709 872 Bytes 5 832 684 320 Bytes -25.0 KiB -0.000%
ydbd stripped size 1 465 156 720 Bytes 1 465 151 344 Bytes -5.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚪ 2024-08-07 15:56:45 UTC Pre-commit check for 99c50fa has started.
⚪ 2024-08-07 16:00:31 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-07 17:46:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38586 33263 0 3 5308 12

⚪ 2024-08-07 17:51:28 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-07 18:00:13 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 8 0 0 1 9

🟢 2024-08-07 18:03:45 UTC Build successful.
🟡 2024-08-07 18:04:20 UTC ydbd size 8.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 142b531 merge: 99c50fa diff diff %
ydbd size 8 672 645 016 Bytes 8 673 845 832 Bytes +1.1 MiB +0.014%
ydbd stripped size 471 989 320 Bytes 472 044 680 Bytes +54.1 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review August 8, 2024 08:24
@ivanmorozov333 ivanmorozov333 merged commit 9dbab08 into ydb-platform:main Aug 8, 2024
@ivanmorozov333 ivanmorozov333 deleted the fix_segfault_in_deserializer_stream branch August 8, 2024 08:24
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
4bf0487
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
2839d40
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
cecca17
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 12, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
7913e7a
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 14, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
1b043e7
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@ivanmorozov333 @zverevgeny
fix segfault in deserializer stream usage (ydb-platform#7542)
ec0a6c2
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanmorozov333 @zverevgeny