Skip to content

Fix integer overflow in TTimeSliceLogic::DoCalcWeight #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fexolm merged 1 commit into from
Aug 9, 2024
Merged

Fix integer overflow in TTimeSliceLogic::DoCalcWeight #7606

fexolm merged 1 commit into from
Aug 9, 2024

Conversation

@fexolm
Copy link
Contributor

@fexolm fexolm commented Aug 9, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@fexolm fexolm requested a review from ivanmorozov333 August 9, 2024 10:02
@fexolm fexolm marked this pull request as ready for review August 9, 2024 10:03
@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:06:08 UTC Pre-commit check for de42c7c has started.
⚪ 2024-08-09 10:08:55 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-09 10:09:53 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:06:29 UTC Pre-commit check for de42c7c has started.
⚫ 2024-08-09 10:09:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:06:43 UTC Pre-commit check for de42c7c has started.
⚪ 2024-08-09 10:09:27 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-09 10:09:53 UTC Check cancelled

@fexolm fexolm changed the title Fix integer overflow Fix integer overflow in TTimeSliceLogic::DoCalcWeight Aug 9, 2024
@fexolm fexolm added bugfix and removed new-feature labels Aug 9, 2024
@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:11:12 UTC Pre-commit check for a936dc6 has started.
⚪ 2024-08-09 10:13:48 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 10:19:00 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:11:12 UTC Pre-commit check for a936dc6 has started.
⚪ 2024-08-09 10:13:50 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 12:24:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9656 9601 0 14 24 17

🟢 2024-08-09 12:25:38 UTC Build successful.
🟢 2024-08-09 12:26:06 UTC ydbd size 5.4 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 403d37f merge: a936dc6 diff diff %
ydbd size 5 843 569 184 Bytes 5 843 569 088 Bytes -96 Bytes -0.000%
ydbd stripped size 1 468 062 000 Bytes 1 468 061 936 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 10:12:01 UTC Pre-commit check for a936dc6 has started.
⚪ 2024-08-09 10:17:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 11:47:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13823 12469 0 3 1338 13

⚪ 2024-08-09 11:48:50 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 11:57:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 9 0 0 1 10

🟢 2024-08-09 11:57:40 UTC Build successful.
🟢 2024-08-09 11:58:12 UTC ydbd size 8.1 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 403d37f merge: a936dc6 diff diff %
ydbd size 8 688 414 328 Bytes 8 688 414 296 Bytes -32 Bytes -0.000%
ydbd stripped size 472 744 808 Bytes 472 744 808 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm merged commit c59279a into ydb-platform:main Aug 9, 2024
@fexolm fexolm deleted the fexolm/fix-CLOUD-195378 branch August 9, 2024 12:51
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
1c0464d 
)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
5bf0db4 
)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
65c76de 
)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 12, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
f321d11 
)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 14, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
b800c50 
)
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@fexolm @zverevgeny
Fix integer overflow in TTimeSliceLogic::DoCalcWeight (ydb-platform#7606
0bf9944 
)
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fexolm @ivanmorozov333