Skip to content

fixes in memory pools #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gridnevvvit merged 2 commits into from
Aug 9, 2024
Merged

fixes in memory pools #7623

gridnevvvit merged 2 commits into from
Aug 9, 2024

Conversation

@gridnevvvit
Copy link
Member

@gridnevvvit gridnevvvit commented Aug 9, 2024

Changelog entry

fixes in memory pools

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@gridnevvvit
fixes in memory pools
cb02506 
* fix changing limit
* add more safety to optional checker
* remove memory pools if it's not used
@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 14:28:09 UTC Pre-commit check for 40d2a29 has started.
⚪ 2024-08-09 14:31:14 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-09 15:01:02 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 14:28:14 UTC Pre-commit check for 40d2a29 has started.
⚪ 2024-08-09 14:31:12 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-09 14:55:52 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 14:28:14 UTC Pre-commit check for 40d2a29 has started.
⚪ 2024-08-09 14:31:17 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 14:50:43 UTC Build failed. see the logs.

GrigoriyPA
GrigoriyPA previously approved these changes Aug 9, 2024
View reviewed changes
dorooleg
dorooleg previously approved these changes Aug 9, 2024
View reviewed changes
@gridnevvvit gridnevvvit dismissed stale reviews from dorooleg and GrigoriyPA via 8ef6e2b August 9, 2024 15:38
@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:42:03 UTC Pre-commit check for 83fbbd3 has started.
⚪ 2024-08-09 15:45:03 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-09 15:51:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:42:03 UTC Pre-commit check for 83fbbd3 has started.
⚪ 2024-08-09 15:45:05 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-09 15:51:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:42:11 UTC Pre-commit check for 83fbbd3 has started.
⚪ 2024-08-09 15:45:15 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-09 15:51:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:52:29 UTC Pre-commit check for 02b14b6 has started.
⚪ 2024-08-09 15:55:31 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 18:22:18 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11094 11032 0 23 23 16

🟢 2024-08-09 18:23:31 UTC Build successful.
🟢 2024-08-09 18:23:58 UTC ydbd size 5.4 GiB changed* by +67.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13d5b4c merge: 02b14b6 diff diff %
ydbd size 5 843 783 352 Bytes 5 843 852 864 Bytes +67.9 KiB +0.001%
ydbd stripped size 1 468 105 872 Bytes 1 468 114 896 Bytes +8.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:54:17 UTC Pre-commit check for 02b14b6 has started.
⚪ 2024-08-09 15:57:24 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 16:07:23 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

⚪ 2024-08-09 15:54:34 UTC Pre-commit check for 02b14b6 has started.
⚪ 2024-08-09 15:57:41 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 17:56:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39885 34557 0 3 5311 14

⚪ 2024-08-09 18:00:43 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 18:07:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 9 0 0 0 8

🟢 2024-08-09 18:07:56 UTC Build successful.
🟢 2024-08-09 18:08:32 UTC ydbd size 8.1 GiB changed* by +86.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 13d5b4c merge: 02b14b6 diff diff %
ydbd size 8 688 685 032 Bytes 8 688 773 072 Bytes +86.0 KiB +0.001%
ydbd stripped size 472 752 520 Bytes 472 754 888 Bytes +2.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit enabled auto-merge (squash) August 9, 2024 18:11
@gridnevvvit gridnevvvit merged commit b569c23 into ydb-platform:main Aug 9, 2024
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
@gridnevvvit gridnevvvit deleted the memory-pools-fixes branch August 30, 2024 13:48
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
@gridnevvvit @lll-phill-lll
fixes in memory pools (ydb-platform#7623)
0782e2b
lll-phill-lll pushed a commit that referenced this pull request Sep 12, 2024
@gridnevvvit @lll-phill-lll
fixes in memory pools (#7623)
6290799
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
@gridnevvvit @lll-phill-lll
fixes in memory pools (ydb-platform#7623)
fd9e64c
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
@gridnevvvit @lll-phill-lll
fixes in memory pools (ydb-platform#7623)
2027101
@lll-phill-lll lll-phill-lll mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorooleg dorooleg dorooleg approved these changes

@GrigoriyPA GrigoriyPA GrigoriyPA left review comments

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gridnevvvit @dorooleg @GrigoriyPA