Skip to content

Add more introspection into PDisk's ChunkWrite and LogWrite #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
va-kuznecov merged 1 commit into from
Aug 20, 2024
Merged

Add more introspection into PDisk's ChunkWrite and LogWrite #7941

va-kuznecov merged 1 commit into from
Aug 20, 2024

Conversation

@va-kuznecov
Copy link
Member

@va-kuznecov va-kuznecov commented Aug 16, 2024 •
edited
Loading

Changelog entry

Add more introspection into PDisk's ChunkWrite and LogWrite

Changelog category

  • Improvement

Additional information

SammyVimes
SammyVimes requested changes Aug 16, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:00:04 UTC Pre-commit check for 28c9a94 has started.
⚪ 2024-08-16 17:03:46 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-16 17:24:18 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:03:55 UTC Pre-commit check for 28c9a94 has started.
⚪ 2024-08-16 17:06:38 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-16 17:24:17 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:11:33 UTC Pre-commit check for 28c9a94 has started.
⚪ 2024-08-16 17:15:17 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-16 17:24:17 UTC Check cancelled

@va-kuznecov va-kuznecov force-pushed the more_intospection_in_pdisk_device branch from d2c5dbd to 5a8f86a Compare August 16, 2024 17:23
@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:25:06 UTC Pre-commit check for 74ef090 has started.
⚪ 2024-08-16 17:28:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-16 17:36:39 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:33:40 UTC Pre-commit check for 74ef090 has started.
⚪ 2024-08-16 17:36:42 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-16 17:51:14 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

⚪ 2024-08-16 17:34:52 UTC Pre-commit check for 74ef090 has started.
⚪ 2024-08-16 17:38:58 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-16 17:47:09 UTC Build failed. see the logs.

@va-kuznecov va-kuznecov force-pushed the more_intospection_in_pdisk_device branch from 5a8f86a to 4a166af Compare August 19, 2024 12:38
@github-actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

⚪ 2024-08-19 12:39:47 UTC Pre-commit check for dd7ee4a has started.
⚪ 2024-08-19 12:42:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-19 13:21:02 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

⚪ 2024-08-19 12:39:48 UTC Pre-commit check for dd7ee4a has started.
⚪ 2024-08-19 12:42:45 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-19 15:24:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11499 11429 0 11 25 34

🟢 2024-08-19 15:25:15 UTC Build successful.
🟢 2024-08-19 15:25:43 UTC ydbd size 5.5 GiB changed* by +86.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8290a51 merge: dd7ee4a diff diff %
ydbd size 5 882 757 384 Bytes 5 882 846 192 Bytes +86.7 KiB +0.002%
ydbd stripped size 1 477 798 256 Bytes 1 477 833 072 Bytes +34.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

⚪ 2024-08-19 12:42:01 UTC Pre-commit check for dd7ee4a has started.
⚪ 2024-08-19 12:44:46 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-19 14:32:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40369 35015 0 6 5313 35

⚪ 2024-08-19 14:36:42 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 14:46:41 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 26 0 0 0 28

🟢 2024-08-19 14:46:49 UTC Build successful.
🟢 2024-08-19 14:47:25 UTC ydbd size 8.1 GiB changed* by +74.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8290a51 merge: dd7ee4a diff diff %
ydbd size 8 741 364 072 Bytes 8 741 439 864 Bytes +74.0 KiB +0.001%
ydbd stripped size 475 663 784 Bytes 475 677 480 Bytes +13.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

SammyVimes
SammyVimes approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-kuznecov va-kuznecov merged commit 5a3ebee into ydb-platform:main Aug 20, 2024
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 21, 2024
Merged
This was referenced Aug 23, 2024
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@va-kuznecov @stanislav-shchetinin
Add more introspection into PDisk's ChunkWrite and LogWrite (ydb-plat…
58b8c98 
…form#7941)

Co-authored-by: Vlad Kuznecov <va-kuznecov@nebius.com>
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
va-kuznecov added a commit to va-kuznecov/ydb that referenced this pull request Sep 12, 2024
@va-kuznecov
Add more introspection into PDisk's ChunkWrite and LogWrite (ydb-plat…
9ed1957 
…form#7941)

Co-authored-by: Vlad Kuznecov <va-kuznecov@nebius.com>
@va-kuznecov va-kuznecov mentioned this pull request Sep 12, 2024
Merged
va-kuznecov added a commit to va-kuznecov/ydb that referenced this pull request Sep 13, 2024
@va-kuznecov
Add more introspection into PDisk's ChunkWrite and LogWrite (ydb-plat…
8fa4bb6 
…form#7941)

Co-authored-by: Vlad Kuznecov <va-kuznecov@nebius.com>
@va-kuznecov va-kuznecov deleted the more_intospection_in_pdisk_device branch July 18, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SammyVimes SammyVimes SammyVimes approved these changes

@alexvru alexvru alexvru approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@va-kuznecov @SammyVimes @alexvru