Skip to content

Improved handling of empty cells in CSV YQ-2727 #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorooleg merged 4 commits into from
Jan 29, 2024
Merged

Improved handling of empty cells in CSV YQ-2727 #796

dorooleg merged 4 commits into from
Jan 29, 2024

Conversation

@dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Dec 28, 2023

No description provided.

@dorooleg dorooleg changed the title csv null poc YQ-2727 csv null poc YQ-2727 (DON'T MERGE) Dec 28, 2023
@github-actions
Copy link

github-actions bot commented Dec 28, 2023 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 44a4f85.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59167 49961 0 23 9172 11

🔴 linux-x86_64-release-asan: some tests FAILED for commit 44a4f85.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15314 15192 0 40 80 2

@dorooleg dorooleg changed the title csv null poc YQ-2727 (DON'T MERGE) csv null poc YQ-2727 Jan 16, 2024
@dorooleg dorooleg requested a review from uzhastik January 16, 2024 22:36
@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 16:45:49 UTC Pre-commit check for 86a5b28 has started.
⚪ 2024-01-24 16:45:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 16:47:30 UTC Build successful.
⚪ 2024-01-24 16:47:43 UTC Tests are running...
🔴 2024-01-24 18:09:39 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60108 50846 0 3 9236 23

@github-actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

⚪ 2024-01-24 16:47:10 UTC Pre-commit check for 86a5b28 has started.
⚪ 2024-01-24 16:47:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 16:48:49 UTC Build successful.
⚪ 2024-01-24 16:48:57 UTC Tests are running...
🔴 2024-01-24 18:19:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15947 15833 0 19 70 25

@dorooleg dorooleg requested a review from a team as a code owner January 24, 2024 09:27
uzhastik
uzhastik reviewed Jan 24, 2024
View reviewed changes
@dorooleg dorooleg changed the title csv null poc YQ-2727 Improved handling of empty cells in CSV YQ-2727 Jan 26, 2024
@dorooleg dorooleg requested a review from vitstn January 26, 2024 13:55
resetius
resetius approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@dorooleg dorooleg merged commit f2ccd9c into ydb-platform:main Jan 29, 2024
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 31, 2024
Closed
This was referenced Feb 8, 2024
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
dorooleg added a commit to dorooleg/ydb that referenced this pull request Feb 23, 2024
@dorooleg
Improved handling of empty cells in CSV YQ-2727 (ydb-platform#796)
584f7ed 
* csv null poc

* cleanup

* not null string as default

* cleanup tests
dorooleg added a commit that referenced this pull request Feb 23, 2024
@dorooleg
Improved handling of empty cells in CSV YQ-2727 (#796) (#2203)
2fb6ff9
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
dorooleg added a commit that referenced this pull request Feb 26, 2024
@dorooleg
merge from main: #1249 #1410 #796 (#2242)
4104260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik approved these changes

@vitstn vitstn Awaiting requested review from vitstn

+1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dorooleg @resetius @uzhastik