Skip to content

[CBO] Join order hints added #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pashandor789 merged 11 commits into from
Aug 26, 2024
Merged

[CBO] Join order hints added #8106

pashandor789 merged 11 commits into from
Aug 26, 2024

Conversation

@pashandor789
Copy link
Contributor

@pashandor789 pashandor789 commented Aug 21, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@pashandor789 pashandor789 requested review from a team as code owners August 21, 2024 12:50
@pashandor789 pashandor789 marked this pull request as draft August 21, 2024 12:51
@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 13:44:23 UTC Pre-commit check for f738aba has started.
⚪ 2024-08-22 13:47:16 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-22 13:50:16 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 13:44:51 UTC Pre-commit check for f738aba has started.
⚪ 2024-08-22 13:48:32 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-22 13:51:37 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 13:48:43 UTC Pre-commit check for f738aba has started.
⚪ 2024-08-22 13:52:52 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-22 13:57:36 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 23:56:34 UTC Pre-commit check for 967ec1b has started.
⚪ 2024-08-22 23:59:25 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-23 00:02:07 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 23:56:50 UTC Pre-commit check for 967ec1b has started.
⚪ 2024-08-22 23:59:43 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 00:03:19 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

⚪ 2024-08-22 23:59:19 UTC Pre-commit check for 967ec1b has started.
⚪ 2024-08-23 00:02:17 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-23 00:04:03 UTC Build failed. see the logs.

@pashandor789 pashandor789 marked this pull request as ready for review August 23, 2024 01:47
@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 01:48:48 UTC Pre-commit check for 30e3fcd has started.
⚫ 2024-08-23 01:51:36 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 01:49:02 UTC Pre-commit check for 30e3fcd has started.
⚫ 2024-08-23 01:51:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 01:53:03 UTC Pre-commit check for 933bbd2 has started.
⚪ 2024-08-23 01:55:46 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 02:00:05 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 01:54:54 UTC Pre-commit check for 933bbd2 has started.
⚪ 2024-08-23 01:57:55 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-23 02:02:31 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 01:57:25 UTC Pre-commit check for 933bbd2 has started.
⚪ 2024-08-23 02:00:19 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-23 02:08:46 UTC Build failed. see the logs.

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 13:35:37 UTC Pre-commit check for 63e8e9d has started.
⚪ 2024-08-23 13:38:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-23 13:54:51 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 13:40:11 UTC Pre-commit check for 63e8e9d has started.
⚪ 2024-08-23 13:43:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 15:21:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15111 15028 0 21 43 19

🟢 2024-08-23 15:22:23 UTC Build successful.
🟡 2024-08-23 15:22:55 UTC ydbd size 5.5 GiB changed* by +127.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6cd8814 merge: 63e8e9d diff diff %
ydbd size 5 896 376 120 Bytes 5 896 506 232 Bytes +127.1 KiB +0.002%
ydbd stripped size 1 481 802 320 Bytes 1 481 836 944 Bytes +33.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 13:48:29 UTC Pre-commit check for 63e8e9d has started.
⚪ 2024-08-23 13:51:39 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 15:12:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77111 63413 0 8 13677 13

⚪ 2024-08-23 15:19:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 15:27:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 14 0 1 0 9

⚪ 2024-08-23 15:27:47 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-23 15:35:34 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 6 0 0 0 9

🟢 2024-08-23 15:35:42 UTC Build successful.
🟡 2024-08-23 15:36:22 UTC ydbd size 8.2 GiB changed* by +175.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6cd8814 merge: 63e8e9d diff diff %
ydbd size 8 760 671 008 Bytes 8 760 850 792 Bytes +175.6 KiB +0.002%
ydbd stripped size 478 027 400 Bytes 478 037 384 Bytes +9.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 15:47:15 UTC Pre-commit check for 6397058 has started.
⚪ 2024-08-23 15:50:14 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 17:54:27 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15120 15009 0 34 58 19

🟢 2024-08-23 17:55:46 UTC Build successful.
🟢 2024-08-23 17:56:15 UTC ydbd size 5.5 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78bb468 merge: 6397058 diff diff %
ydbd size 5 898 210 008 Bytes 5 898 221 992 Bytes +11.7 KiB +0.000%
ydbd stripped size 1 482 089 712 Bytes 1 482 097 904 Bytes +8.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 15:48:28 UTC Pre-commit check for 6397058 has started.
⚪ 2024-08-23 15:51:19 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 17:27:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77142 63440 0 7 13676 19

⚪ 2024-08-23 17:35:10 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-23 17:42:14 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 17 0 0 0 9

🟢 2024-08-23 17:42:21 UTC Build successful.
🟢 2024-08-23 17:42:58 UTC ydbd size 8.2 GiB changed* by +91.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78bb468 merge: 6397058 diff diff %
ydbd size 8 763 487 936 Bytes 8 763 581 760 Bytes +91.6 KiB +0.001%
ydbd stripped size 478 097 576 Bytes 478 100 200 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pashandor789 pashandor789 self-assigned this Aug 23, 2024
@pashandor789 pashandor789 linked an issue Aug 23, 2024 that may be closed by this pull request
Implement Join Order hints #7917
Closed
@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 02:29:45 UTC Pre-commit check for ac669bf has started.
⚪ 2024-08-26 02:32:48 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 02:51:59 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 02:30:02 UTC Pre-commit check for ac669bf has started.
⚪ 2024-08-26 02:33:06 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 03:57:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77150 63433 0 11 13679 27

⚪ 2024-08-26 04:05:32 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 04:13:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 24 0 0 1 9

🟢 2024-08-26 04:13:13 UTC Build successful.
🟡 2024-08-26 04:13:48 UTC ydbd size 8.2 GiB changed* by +180.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7b38864 merge: ac669bf diff diff %
ydbd size 8 790 511 408 Bytes 8 790 696 672 Bytes +180.9 KiB +0.002%
ydbd stripped size 479 517 928 Bytes 479 526 568 Bytes +8.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 02:30:29 UTC Pre-commit check for ac669bf has started.
⚪ 2024-08-26 02:33:32 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 04:34:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15133 14968 0 63 78 24

🟢 2024-08-26 04:35:27 UTC Build successful.
🟢 2024-08-26 04:36:06 UTC ydbd size 5.5 GiB changed* by +92.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7b38864 merge: ac669bf diff diff %
ydbd size 5 922 899 160 Bytes 5 922 993 672 Bytes +92.3 KiB +0.002%
ydbd stripped size 1 487 939 408 Bytes 1 487 961 488 Bytes +21.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pavelvelikhov
pavelvelikhov previously approved these changes Aug 26, 2024
View reviewed changes
resetius
resetius reviewed Aug 26, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:58:53 UTC Pre-commit check for 9e690d0 has started.
⚪ 2024-08-26 14:02:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 15:39:18 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15122 15025 0 31 51 15

🟢 2024-08-26 15:40:33 UTC Build successful.
🟢 2024-08-26 15:41:04 UTC ydbd size 5.5 GiB changed* by +95.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43019e6 merge: 9e690d0 diff diff %
ydbd size 5 925 799 544 Bytes 5 925 897 728 Bytes +95.9 KiB +0.002%
ydbd stripped size 1 488 593 520 Bytes 1 488 619 632 Bytes +25.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 14:00:32 UTC Pre-commit check for 9e690d0 has started.
⚪ 2024-08-26 14:04:11 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 14:16:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 14:03:59 UTC Pre-commit check for 9e690d0 has started.
⚪ 2024-08-26 14:07:55 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 15:25:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77170 63392 0 83 13677 18

⚪ 2024-08-26 15:32:44 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 15:40:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
103 (only retried tests) 64 0 29 0 10

⚪ 2024-08-26 15:40:34 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 15:47:55 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
44 (only retried tests) 34 0 0 0 10

🟢 2024-08-26 15:48:03 UTC Build successful.
🟡 2024-08-26 15:48:40 UTC ydbd size 8.2 GiB changed* by +184.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 43019e6 merge: 9e690d0 diff diff %
ydbd size 8 795 033 768 Bytes 8 795 222 376 Bytes +184.2 KiB +0.002%
ydbd stripped size 479 689 064 Bytes 479 701 736 Bytes +12.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pashandor789 pashandor789 enabled auto-merge (squash) August 26, 2024 18:44
@pashandor789 pashandor789 merged commit d9ff14c into ydb-platform:main Aug 26, 2024
This was referenced Aug 27, 2024
Merged
Merged
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@pashandor789 @rekby
[CBO] Join order hints added (ydb-platform#8106)
733c583
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@pashandor789 @stanislav-shchetinin
[CBO] Join order hints added (ydb-platform#8106)
df4401a
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
pavelvelikhov pushed a commit to pavelvelikhov/ydb that referenced this pull request Sep 5, 2024
@pashandor789 @pavelvelikhov
[CBO] Join order hints added (ydb-platform#8106)
4eb4a9b
This was referenced Sep 9, 2024
Merged
Merged
This was referenced Sep 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spuchin spuchin spuchin approved these changes

@pavelvelikhov pavelvelikhov pavelvelikhov left review comments

+1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pashandor789 pashandor789

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Join Order hints

4 participants

@pashandor789 @resetius @pavelvelikhov @spuchin