Skip to content

Do not fill tables for prepared query on compilation failure #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abyss7 merged 2 commits into from
Aug 26, 2024
Merged

Do not fill tables for prepared query on compilation failure #8210

abyss7 merged 2 commits into from
Aug 26, 2024

Conversation

@abyss7
Copy link
Collaborator

@abyss7 abyss7 commented Aug 23, 2024 •
edited
Loading

Changelog entry

Fix for #7989

Changelog category

  • Improvement

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 12:38:50 UTC Pre-commit check for 2d02ecb has started.
⚪ 2024-08-23 12:41:34 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-23 12:46:50 UTC Build successful.

@abyss7 abyss7 changed the title [#7989] Do not invoke FillCompileResult() on compilation failure Do not invoke FillCompileResult() on compilation failure Aug 23, 2024
@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 12:39:30 UTC Pre-commit check for 2d02ecb has started.
⚪ 2024-08-23 12:42:15 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 14:04:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9911 9836 0 26 29 20

🟢 2024-08-23 14:05:22 UTC Build successful.
🟢 2024-08-23 14:05:51 UTC ydbd size 5.5 GiB changed* by +752 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 88a86d9 merge: 2d02ecb diff diff %
ydbd size 5 896 633 472 Bytes 5 896 634 224 Bytes +752 Bytes +0.000%
ydbd stripped size 1 481 806 480 Bytes 1 481 806 416 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 12:39:31 UTC Pre-commit check for 2d02ecb has started.
⚪ 2024-08-23 12:42:19 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 13:40:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14323 12947 0 11 1348 17

⚪ 2024-08-23 13:41:57 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 13:50:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 17 0 2 1 10

⚪ 2024-08-23 13:50:34 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-23 13:58:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 5 0 2 0 10

🟢 2024-08-23 13:59:01 UTC Build successful.
🟢 2024-08-23 13:59:35 UTC ydbd size 8.2 GiB changed* by +208 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 88a86d9 merge: 2d02ecb diff diff %
ydbd size 8 760 870 312 Bytes 8 760 870 520 Bytes +208 Bytes +0.000%
ydbd stripped size 478 028 872 Bytes 478 028 872 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@abyss7 abyss7 changed the title Do not invoke FillCompileResult() on compilation failure Do not fill tables for prepared query on compilation failure Aug 24, 2024
@github-actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 15:23:08 UTC Pre-commit check for caffead has started.
⚪ 2024-08-24 15:25:54 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-24 16:57:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10066 9980 0 30 41 15

🟢 2024-08-24 16:57:56 UTC Build successful.
🟢 2024-08-24 16:58:24 UTC ydbd size 5.5 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b5dba78 merge: caffead diff diff %
ydbd size 5 919 113 664 Bytes 5 919 114 744 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 487 402 544 Bytes 1 487 402 416 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 15:23:42 UTC Pre-commit check for caffead has started.
⚪ 2024-08-24 15:26:32 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 16:29:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39196 33800 0 11 5359 26

⚪ 2024-08-24 16:33:12 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-24 16:40:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 21 0 2 1 10

⚪ 2024-08-24 16:40:46 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-24 16:47:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 7 0 0 0 10

🟢 2024-08-24 16:47:41 UTC Build successful.
🟢 2024-08-24 16:48:17 UTC ydbd size 8.2 GiB changed* by -23.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 92ff6c1 merge: caffead diff diff %
ydbd size 8 784 784 440 Bytes 8 784 760 408 Bytes -23.5 KiB -0.000%
ydbd stripped size 479 498 440 Bytes 479 384 264 Bytes -111.5 KiB -0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

⚪ 2024-08-24 15:23:44 UTC Pre-commit check for caffead has started.
⚪ 2024-08-24 15:26:34 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-24 15:35:41 UTC Build successful.

@abyss7 abyss7 merged commit 3be09f1 into ydb-platform:main Aug 26, 2024
This was referenced Aug 27, 2024
Merged
Merged
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@abyss7 @rekby
Do not fill tables for prepared query on compilation failure (ydb-pla…
3c91f7e 
…tform#8210)
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@abyss7 @stanislav-shchetinin
Do not fill tables for prepared query on compilation failure (ydb-pla…
b9d50aa 
…tform#8210)
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
abyss7 added a commit to abyss7/ydb that referenced this pull request Sep 9, 2024
@abyss7
Do not fill tables for prepared query on compilation failure (ydb-pla…
89cb722 
…tform#8210)

(cherry picked from commit 3be09f1)
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
This was referenced Sep 17, 2024
Merged
Merged
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Sep 30, 2024
@abyss7 @gridnevvvit
Do not fill tables for prepared query on compilation failure (ydb-pla…
885c359 
…tform#8210)
@gridnevvvit gridnevvvit mentioned this pull request Sep 30, 2024
Merged
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Sep 30, 2024
@abyss7 @gridnevvvit
Do not fill tables for prepared query on compilation failure (ydb-pla…
4d4267a 
…tform#8210)
@gridnevvvit gridnevvvit mentioned this pull request Sep 30, 2024
Merged
gridnevvvit added a commit that referenced this pull request Sep 30, 2024
@gridnevvvit @abyss7
Do not fill tables for prepared query on compilation failure (#8210) (#…
8bc6521 
…9911)

Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
gridnevvvit added a commit that referenced this pull request Sep 30, 2024
@gridnevvvit @abyss7
Do not fill tables for prepared query on compilation failure (#8210) (#…
56881e1 
…9910)

Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 7, 2024
@gridnevvvit @abyss7 @uzhastik
Do not fill tables for prepared query on compilation failure (ydb-pla…
245ae02 
…tform#8210) (ydb-platform#9910)

Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
This was referenced Oct 29, 2024
Closed
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abyss7 @gridnevvvit