Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheme connection has been supported #8232

Merged
merged 2 commits into from
Aug 27, 2024
Merged

scheme connection has been supported #8232

merged 2 commits into from
Aug 27, 2024

Conversation

dorooleg
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@dorooleg dorooleg requested a review from a team as a code owner August 23, 2024 21:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 21:30:45 UTC Pre-commit check for 89972b0 has started.
⚪ 2024-08-23 21:33:44 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-23 21:36:31 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 21:30:51 UTC Pre-commit check for 89972b0 has started.
⚪ 2024-08-23 21:33:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 21:38:24 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚪ 2024-08-23 21:31:10 UTC Pre-commit check for 89972b0 has started.
⚪ 2024-08-23 21:34:14 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-23 21:36:48 UTC Build failed. see the logs.

uzhastik
uzhastik reviewed Aug 24, 2024
View reviewed changes
ydb/core/fq/libs/config/protos/compute.proto Outdated
@@ -44,6 +44,7 @@ message TWorkloadManagerConfig {

message TComputeDatabaseConfig {
TYdbStorageConfig ControlPlaneConnection = 1;
TYdbStorageConfig SchemeConnection = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id 3 уже используется

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 08:14:04 UTC Pre-commit check for 99a1a4c has started.
⚪ 2024-08-27 08:17:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-27 10:18:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11406 11292 0 38 49 27

🟢 2024-08-27 10:19:58 UTC Build successful.
🟢 2024-08-27 10:20:32 UTC ydbd size 5.5 GiB changed* by +16.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2848978 merge: 99a1a4c diff diff %
ydbd size 5 927 286 976 Bytes 5 927 303 976 Bytes +16.6 KiB +0.000%
ydbd stripped size 1 488 933 488 Bytes 1 488 943 248 Bytes +9.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 08:22:14 UTC Pre-commit check for 99a1a4c has started.
⚪ 2024-08-27 08:25:19 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-27 09:55:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40579 35187 0 13 5362 17

⚪ 2024-08-27 09:58:57 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-27 10:09:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32 (only retried tests) 22 0 0 0 10

🟢 2024-08-27 10:09:18 UTC Build successful.
🟢 2024-08-27 10:09:59 UTC ydbd size 8.2 GiB changed* by +11.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2848978 merge: 99a1a4c diff diff %
ydbd size 8 797 463 096 Bytes 8 797 474 448 Bytes +11.1 KiB +0.000%
ydbd stripped size 479 817 736 Bytes 479 818 184 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

⚪ 2024-08-27 08:22:21 UTC Pre-commit check for 99a1a4c has started.
⚪ 2024-08-27 08:25:23 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-27 09:02:13 UTC Build successful.

@dorooleg dorooleg merged commit e539101 into ydb-platform:main Aug 27, 2024
10 of 12 checks passed
@dorooleg dorooleg deleted the scheme_connection_has_been_supported branch August 27, 2024 16:41
dorooleg added a commit to dorooleg/ydb that referenced this pull request Aug 28, 2024
@dorooleg
scheme connection has been supported (ydb-platform#8232)
677d756
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@dorooleg @rekby
scheme connection has been supported (ydb-platform#8232)
d1bca01
dorooleg added a commit that referenced this pull request Aug 28, 2024
@dorooleg
scheme connection has been supported (#8232) (#8384)
f0a5389
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@dorooleg @stanislav-shchetinin
scheme connection has been supported (ydb-platform#8232)
998cdf7
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
This was referenced Sep 17, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik left review comments

@Hor911 Hor911 Hor911 approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorooleg @Hor911 @uzhastik