Skip to content

Allow to alter cdc topic's retention period #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyberROFL merged 2 commits into from
Aug 26, 2024
Merged

Allow to alter cdc topic's retention period #8264

CyberROFL merged 2 commits into from
Aug 26, 2024

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Aug 26, 2024 •
edited
Loading

Changelog entry

Allow to alter CDC topic's retention period using ALTER TOPIC.

Changelog category

  • New feature

Additional information

...

@CyberROFL CyberROFL requested a review from alexnick88 August 26, 2024 10:46
@CyberROFL CyberROFL self-assigned this Aug 26, 2024
@CyberROFL CyberROFL marked this pull request as ready for review August 26, 2024 10:48
@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 10:49:42 UTC Pre-commit check for 17c75f5 has started.
⚪ 2024-08-26 10:52:32 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 11:00:06 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 10:49:52 UTC Pre-commit check for 17c75f5 has started.
⚪ 2024-08-26 10:52:37 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 12:16:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9921 9819 0 36 48 18

🟢 2024-08-26 12:17:53 UTC Build successful.
🟢 2024-08-26 12:18:25 UTC ydbd size 5.5 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3be09f1 merge: 17c75f5 diff diff %
ydbd size 5 923 328 576 Bytes 5 923 329 920 Bytes +1.3 KiB +0.000%
ydbd stripped size 1 488 017 776 Bytes 1 488 018 032 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 10:52:55 UTC Pre-commit check for 17c75f5 has started.
⚪ 2024-08-26 10:55:49 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 11:55:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14332 12935 0 26 1349 22

⚪ 2024-08-26 11:57:08 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 12:06:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 (only retried tests) 35 0 1 0 9

⚪ 2024-08-26 12:06:13 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-26 12:13:38 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 6 0 1 0 9

🟢 2024-08-26 12:13:45 UTC Build successful.
🟢 2024-08-26 12:14:25 UTC ydbd size 8.2 GiB changed* by +752 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3be09f1 merge: 17c75f5 diff diff %
ydbd size 8 790 916 288 Bytes 8 790 917 040 Bytes +752 Bytes +0.000%
ydbd stripped size 479 547 464 Bytes 479 547 464 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Aug 26, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:16:11 UTC Pre-commit check for 71adff7 has started.
⚪ 2024-08-26 13:20:02 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 14:49:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9925 9826 0 36 45 18

🟢 2024-08-26 14:50:35 UTC Build successful.
🟢 2024-08-26 14:51:04 UTC ydbd size 5.5 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43019e6 merge: 71adff7 diff diff %
ydbd size 5 925 799 544 Bytes 5 925 800 936 Bytes +1.4 KiB +0.000%
ydbd stripped size 1 488 593 520 Bytes 1 488 593 840 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:39:31 UTC Pre-commit check for 71adff7 has started.
⚪ 2024-08-26 13:43:17 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 14:40:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14332 12937 0 28 1351 16

⚪ 2024-08-26 14:41:23 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 14:51:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 38 0 0 0 9

🟢 2024-08-26 14:51:18 UTC Build successful.
🟢 2024-08-26 14:51:54 UTC ydbd size 8.2 GiB changed* by +688 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43019e6 merge: 71adff7 diff diff %
ydbd size 8 795 033 768 Bytes 8 795 034 456 Bytes +688 Bytes +0.000%
ydbd stripped size 479 689 064 Bytes 479 689 000 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:40:07 UTC Pre-commit check for 71adff7 has started.
⚪ 2024-08-26 13:43:49 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 13:49:31 UTC Build successful.

@CyberROFL CyberROFL enabled auto-merge (squash) August 26, 2024 13:44
@CyberROFL CyberROFL merged commit 3c06027 into ydb-platform:main Aug 26, 2024
@CyberROFL CyberROFL deleted the alter-cdc-retention-period branch August 26, 2024 14:54
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Aug 26, 2024
@CyberROFL
Allow to alter cdc topic's retention period (ydb-platform#8264)
0ca09ef
This was referenced Aug 27, 2024
Merged
Merged
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@CyberROFL @rekby
Allow to alter cdc topic's retention period (ydb-platform#8264)
2dee517
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@CyberROFL @stanislav-shchetinin
Allow to alter cdc topic's retention period (ydb-platform#8264)
f750bdb
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
This was referenced Sep 17, 2024
Merged
Merged
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

🟢 2025-04-16 09:44:19 UTC The validation of the Pull Request description is successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

@CyberROFL CyberROFL

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CyberROFL @alexnick88