Skip to content

Fix PDisk config is being overwritten #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SammyVimes merged 1 commit into from
Aug 30, 2024
Merged

Fix PDisk config is being overwritten #8388

SammyVimes merged 1 commit into from
Aug 30, 2024

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Aug 28, 2024

Changelog category

  • Bugfix

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 12:47:32 UTC Pre-commit check for 4d6fb5d has started.
⚪ 2024-08-28 12:51:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-28 14:24:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10174 10099 0 27 28 20

🟢 2024-08-28 14:25:54 UTC Build successful.
🔴 2024-08-28 14:26:25 UTC ydbd size 5.5 GiB changed* by +3.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e7b25a7 merge: 4d6fb5d diff diff %
ydbd size 5 929 547 592 Bytes 5 933 609 056 Bytes +3.9 MiB +0.068%
ydbd stripped size 1 489 205 168 Bytes 1 490 292 880 Bytes +1.0 MiB +0.073%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 12:50:51 UTC Pre-commit check for 4d6fb5d has started.
⚪ 2024-08-28 12:54:48 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-28 13:49:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14764 13390 0 4 1357 13

⚪ 2024-08-28 13:51:08 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-28 13:59:36 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 16 0 0 0 11

🟢 2024-08-28 13:59:43 UTC Build successful.
🔴 2024-08-28 14:00:18 UTC ydbd size 8.2 GiB changed* by +4.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e7b25a7 merge: 4d6fb5d diff diff %
ydbd size 8 801 105 584 Bytes 8 806 267 000 Bytes +4.9 MiB +0.059%
ydbd stripped size 479 886 856 Bytes 480 202 024 Bytes +307.8 KiB +0.066%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 12:54:26 UTC Pre-commit check for 4d6fb5d has started.
⚪ 2024-08-28 12:58:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-28 13:03:48 UTC Build successful.

@SammyVimes SammyVimes requested a review from alexvru August 28, 2024 13:48
va-kuznecov
va-kuznecov approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@va-kuznecov va-kuznecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

also got verbal OK from cthulhu

@SammyVimes SammyVimes merged commit 9fe138b into ydb-platform:main Aug 30, 2024
@SammyVimes SammyVimes deleted the fix-pdisk-config-overwritten branch August 30, 2024 10:43
SammyVimes added a commit to SammyVimes/ydb that referenced this pull request Aug 30, 2024
@SammyVimes
Fix PDisk config is being overwritten (ydb-platform#8388)
8c7ecb7 
(cherry picked from commit 9fe138b)
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
Merged
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
SammyVimes added a commit to SammyVimes/ydb that referenced this pull request Sep 17, 2024
@SammyVimes
Fix PDisk config is being overwritten (ydb-platform#8388)
c6e69b7 
(cherry picked from commit 9fe138b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@va-kuznecov va-kuznecov va-kuznecov approved these changes

@alexvru alexvru Awaiting requested review from alexvru

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SammyVimes @va-kuznecov