Skip to content

Merge into 24-3. Add new INFO LOG message for groups which cannot be healed by SelfHeal #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
va-kuznecov merged 1 commit into from
Sep 3, 2024
Merged

Merge into 24-3. Add new INFO LOG message for groups which cannot be healed by SelfHeal #8628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ydb/core/mind/bscontroller/self_heal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,28 @@ namespace NKikimr::NBsController {
*v, group.Topology, isSelfHealReasonDecommit, DonorMode));
} else {
++counter; // this group can't be reassigned right now

auto log = [&]() {
TStringStream ss;
ss << "[";
bool first = true;
for (const auto& [vdiskId, vdisk] : group.Content.VDisks) {
if (!std::exchange(first, false)) {
ss << ",";
}
ss << "{";
ss << vdiskId;
ss << (IsReady(vdisk, now) ? " Ready" : " NotReady");
ss << (vdisk.Faulty ? " Faulty" : "");
ss << (vdisk.Bad ? " IsBad" : "");
ss << (vdisk.Decommitted ? " Decommitted" : "");
ss << "}";
}
ss << "]";
return ss.Str();
};

STLOG(PRI_INFO, BS_SELFHEAL, BSSH11, "group can't be reassigned right now " << log(), (GroupId, group.GroupId));
}
}

Expand Down