Skip to content

Add const to the condition function #8644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azevaykin merged 1 commit into from
Sep 3, 2024
Merged

Add const to the condition function #8644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/testlib/actors/block_events.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace NActors {
template<class TEvType>
class TBlockEvents : public std::deque<typename TEvType::TPtr> {
public:
TBlockEvents(TTestActorRuntime& runtime, std::function<bool(typename TEvType::TPtr&)> condition = {})
TBlockEvents(TTestActorRuntime& runtime, std::function<bool(const typename TEvType::TPtr&)> condition = {})
: Runtime(runtime)
, Condition(std::move(condition))
, Holder(Runtime.AddObserver<TEvType>(
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/testlib/actors/test_runtime_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ Y_UNIT_TEST_SUITE(TActorTest) {
auto source = runtime.Register(new TSourceActor(target), /* nodeIdx */ 1);
runtime.EnableScheduleForActor(source);

TBlockEvents<TEvTrigger> block(runtime, [&](TEvTrigger::TPtr& ev){ return ev->GetRecipientRewrite() == target; });
TBlockEvents<TEvTrigger> block(runtime, [&](const TEvTrigger::TPtr& ev){ return ev->GetRecipientRewrite() == target; });
runtime.WaitFor("blocked 3 events", [&]{ return block.size() >= 3; });
UNIT_ASSERT_VALUES_EQUAL(block.size(), 3u);
UNIT_ASSERT_VALUES_EQUAL(values.size(), 0u);
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tx/datashard/datashard_ut_build_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ Y_UNIT_TEST_SUITE(TTxDataShardBuildIndexScan) {

CreateShardedTableForIndex(server, sender, "/Root", "table-2", 1, false);

TBlockEvents<TEvDataShard::TEvCompactBorrowed> block(runtime, [&](TEvDataShard::TEvCompactBorrowed::TPtr& event) {
TBlockEvents<TEvDataShard::TEvCompactBorrowed> block(runtime, [&](const TEvDataShard::TEvCompactBorrowed::TPtr& event) {
return runtime.FindActorName(event->Sender) == "FLAT_SCHEMESHARD_ACTOR";
});

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tx/datashard/datashard_ut_stats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ Y_UNIT_TEST_SUITE(DataShardStats) {

UpsertRows(server, sender);

TBlockEvents<NSharedCache::TEvResult> block(runtime, [&](NSharedCache::TEvResult::TPtr& event) {
TBlockEvents<NSharedCache::TEvResult> block(runtime, [&](const NSharedCache::TEvResult::TPtr& event) {
return runtime.FindActorName(event->GetRecipientRewrite()) == "DATASHARD_STATS_BUILDER";
});

Expand Down
6 changes: 3 additions & 3 deletions ydb/core/tx/mediator/mediator_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ Y_UNIT_TEST_SUITE(MediatorTest) {

// Block plan steps at tablet 1
TBlockEvents<TEvTxProcessing::TEvPlanStep> blockedPlan1(runtime,
[&](TEvTxProcessing::TEvPlanStep::TPtr& ev) {
[&](const TEvTxProcessing::TEvPlanStep::TPtr& ev) {
return ev->Get()->Record.GetTabletID() == tablet1;
});

Expand Down Expand Up @@ -943,12 +943,12 @@ Y_UNIT_TEST_SUITE(MediatorTest) {
WatcherState->Updates.clear();

TBlockEvents<TEvTxProcessing::TEvPlanStep> blockedPlan1(runtime,
[&](TEvTxProcessing::TEvPlanStep::TPtr& ev) {
[&](const TEvTxProcessing::TEvPlanStep::TPtr& ev) {
return ev->Get()->Record.GetTabletID() == tablet1;
});

TBlockEvents<TEvTxProcessing::TEvPlanStep> blockedPlan2(runtime,
[&](TEvTxProcessing::TEvPlanStep::TPtr& ev) {
[&](const TEvTxProcessing::TEvPlanStep::TPtr& ev) {
return ev->Get()->Record.GetTabletID() == tablet2;
});

Expand Down
4 changes: 2 additions & 2 deletions ydb/core/tx/time_cast/time_cast_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ namespace NKikimr::NMediatorTimeCastTest {

TBlockEvents<TEvTxProcessing::TEvPlanStepAck> blockAcks(runtime);
TBlockEvents<TEvTxProcessing::TEvPlanStep> blockPlan1(runtime,
[&](auto& ev) { return ev->Get()->Record.GetTabletID() == tablet1; });
[&](const auto& ev) { return ev->Get()->Record.GetTabletID() == tablet1; });
TBlockEvents<TEvTxProcessing::TEvPlanStep> blockPlan2(runtime,
[&](auto& ev) { return ev->Get()->Record.GetTabletID() == tablet2; });
[&](const auto& ev) { return ev->Get()->Record.GetTabletID() == tablet2; });

ui64 stepTx1 = PlanTx(server, 1, { tablet1, tablet2 });
Cerr << "... tx1 planned at step " << stepTx1 << Endl;
Expand Down