Skip to content

Conversation

@vitstn
Copy link
Collaborator

@vitstn vitstn commented Sep 11, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@vitstn vitstn requested a review from a team as a code owner September 11, 2024 12:00
@vitstn vitstn added the area/pg label Sep 11, 2024
@vitstn vitstn requested a review from MrLolthe1st September 11, 2024 12:01
@vitstn vitstn enabled auto-merge (squash) September 11, 2024 12:01
@github-actions
Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 12:10:12 UTC Pre-commit check linux-x86_64-release-asan for 556e760 has started.
2024-09-11 12:10:49 UTC Artifacts will be uploaded here
2024-09-11 12:13:41 UTC ya make is running...
🔴 2024-09-11 13:04:44 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5023 4863 0 14 58 88

🟢 2024-09-11 13:05:14 UTC Build successful.
🟢 2024-09-11 13:05:42 UTC ydbd size 5.6 GiB changed* by +7.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6d081d merge: 556e760 diff diff %
ydbd size 6 040 865 736 Bytes 6 040 873 224 Bytes +7.3 KiB +0.000%
ydbd stripped size 1 511 651 216 Bytes 1 511 653 072 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 12:10:12 UTC Pre-commit check linux-x86_64-release-clang14 for 556e760 has started.
2024-09-11 12:10:58 UTC Artifacts will be uploaded here
2024-09-11 12:13:51 UTC ya make is running...
🟢 2024-09-11 12:17:17 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

2024-09-11 12:16:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 556e760 has started.
2024-09-11 12:17:17 UTC Artifacts will be uploaded here
2024-09-11 12:20:17 UTC ya make is running...
🟢 2024-09-11 13:05:55 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67037 53176 0 0 13783 78

🟢 2024-09-11 13:13:12 UTC Build successful.
🟢 2024-09-11 13:13:44 UTC ydbd size 8.4 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6d081d merge: 556e760 diff diff %
ydbd size 9 029 184 440 Bytes 9 029 186 664 Bytes +2.2 KiB +0.000%
ydbd stripped size 487 842 312 Bytes 487 842 568 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn requested a review from igormunkin September 11, 2024 12:34
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM as trivial.

@vitstn vitstn merged commit 5a49f64 into ydb-platform:main Sep 11, 2024
@vitstn vitstn deleted the check_guc_str_len branch September 11, 2024 13:14
shnikd pushed a commit to shnikd/ydb that referenced this pull request Sep 11, 2024
shnikd pushed a commit to shnikd/ydb that referenced this pull request Sep 11, 2024
shnikd pushed a commit to shnikd/ydb that referenced this pull request Sep 12, 2024
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 7, 2024
uzhastik added a commit that referenced this pull request Nov 7, 2024
Co-authored-by: Vitaly Stoyan <vvvv@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants