Skip to content

Conversation

@robdrynkin
Copy link
Collaborator

  • Not for changelog (changelog entry is not required)

@robdrynkin robdrynkin changed the title Blobs balancing improvements 2 Balancing: add new limits, timeouts and sensors, fix blob on main by ingress, but not realy Sep 13, 2024
@github-actions
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 15:59:35 UTC Pre-commit check linux-x86_64-release-clang14 for c04c8fd has started.
2024-09-13 15:59:39 UTC Artifacts will be uploaded here
2024-09-13 16:02:50 UTC ya make is running...
🟢 2024-09-13 16:39:50 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 16:00:37 UTC Pre-commit check linux-x86_64-release-asan for c04c8fd has started.
2024-09-13 16:01:20 UTC Artifacts will be uploaded here
2024-09-13 16:05:10 UTC ya make is running...
🔴 2024-09-13 18:04:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11837 11485 0 53 31 268

🟢 2024-09-13 18:05:49 UTC Build successful.
🟡 2024-09-13 18:06:20 UTC ydbd size 5.6 GiB changed* by +310.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ba01fbb merge: c04c8fd diff diff %
ydbd size 6 053 253 792 Bytes 6 053 571 448 Bytes +310.2 KiB +0.005%
ydbd stripped size 1 514 926 064 Bytes 1 515 003 760 Bytes +75.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 16:01:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for c04c8fd has started.
2024-09-13 16:01:59 UTC Artifacts will be uploaded here
2024-09-13 16:05:12 UTC ya make is running...
🟡 2024-09-13 17:42:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41158 35452 0 6 5670 30

2024-09-13 17:46:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-13 17:53:34 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
274 (only retried tests) 182 0 0 8 84

🟢 2024-09-13 17:53:42 UTC Build successful.
🟡 2024-09-13 17:54:23 UTC ydbd size 8.4 GiB changed* by +392.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ba01fbb merge: c04c8fd diff diff %
ydbd size 9 044 345 224 Bytes 9 044 747 032 Bytes +392.4 KiB +0.004%
ydbd stripped size 488 940 488 Bytes 488 964 680 Bytes +23.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation


merger.Clear();

if (SendOnMainParts.Size() >= MAX_TO_SEND_PER_EPOCH && TryDeleteParts.Size() >= MAX_TO_DELETE_PER_EPOCH) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe || ?

if any of limits is exceeded actor should stop.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thats not a mistake, I check TryDeleteParts.Size() < MAX_TO_DELETE_PER_EPOCH and SendOnMainParts.Size() < MAX_TO_SEND_PER_EPOCH above before pushing to queues. If I will check ||, there could be a situation when I will only send parts on main for a long time, without deletes

@robdrynkin robdrynkin merged commit c09a984 into ydb-platform:main Sep 16, 2024
@shnikd shnikd mentioned this pull request Sep 19, 2024
robdrynkin added a commit to robdrynkin/ydb that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants