Skip to content

Limit inflight cross-database scheme requests in the replication controller #9334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyberROFL merged 1 commit into from
Sep 17, 2024
Merged

Limit inflight cross-database scheme requests in the replication controller #9334

CyberROFL merged 1 commit into from
Sep 17, 2024

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 16, 2024 •
edited
Loading

Changelog entry

Limit inflight cross-database scheme requests in the replication controller.

Changelog category

  • Improvement

Additional information

...

@CyberROFL CyberROFL requested a review from Enjection September 16, 2024 17:28
@CyberROFL CyberROFL linked an issue Sep 16, 2024 that may be closed by this pull request
Limit inflight scheme requests from Replication controller #9294
Closed
@CyberROFL CyberROFL marked this pull request as ready for review September 16, 2024 17:29
@CyberROFL CyberROFL enabled auto-merge (squash) September 16, 2024 17:30
@github-actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

⚪ 2024-09-16 17:39:57 UTC Pre-commit check linux-x86_64-release-clang14 for 3469ca4 has started.
⚪ 2024-09-16 17:40:25 UTC Artifacts will be uploaded here
⚪ 2024-09-16 17:43:37 UTC ya make is running...
🟢 2024-09-16 18:31:17 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

⚪ 2024-09-16 17:41:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3469ca4 has started.
⚪ 2024-09-16 17:42:01 UTC Artifacts will be uploaded here
⚪ 2024-09-16 17:45:43 UTC ya make is running...
🟡 2024-09-16 19:24:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41208 35495 0 7 5437 269

⚪ 2024-09-16 19:28:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-16 19:38:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
285 (only retried tests) 192 0 0 8 85

🟢 2024-09-16 19:38:47 UTC Build successful.
🟢 2024-09-16 19:39:22 UTC ydbd size 8.4 GiB changed* by +74.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4dc00f1 merge: 3469ca4 diff diff %
ydbd size 9 030 034 752 Bytes 9 030 111 048 Bytes +74.5 KiB +0.001%
ydbd stripped size 488 713 864 Bytes 488 720 488 Bytes +6.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

⚪ 2024-09-16 17:51:36 UTC Pre-commit check linux-x86_64-release-asan for 3469ca4 has started.
⚪ 2024-09-16 17:51:46 UTC Artifacts will be uploaded here
⚪ 2024-09-16 17:55:06 UTC ya make is running...
🔴 2024-09-16 20:22:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11869 11479 0 52 291 47

🟢 2024-09-16 20:23:41 UTC Build successful.
🟢 2024-09-16 20:24:18 UTC ydbd size 5.6 GiB changed* by +65.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4dc00f1 merge: 3469ca4 diff diff %
ydbd size 6 045 019 344 Bytes 6 045 086 760 Bytes +65.8 KiB +0.001%
ydbd stripped size 1 512 988 656 Bytes 1 513 001 040 Bytes +12.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL disabled auto-merge September 16, 2024 20:38
Enjection
Enjection previously approved these changes Sep 17, 2024
View reviewed changes
@CyberROFL CyberROFL requested a review from Enjection September 17, 2024 11:40
@CyberROFL CyberROFL changed the title Limit inflight requests when creating a changefeed in the replication controller Limit inflight cross-database scheme requests in the replication controller Sep 17, 2024
@CyberROFL CyberROFL enabled auto-merge (squash) September 17, 2024 11:41
@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 11:41:16 UTC Pre-commit check linux-x86_64-release-asan for d503a6d has started.
⚪ 2024-09-17 11:41:56 UTC Artifacts will be uploaded here
⚫ 2024-09-17 11:44:21 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 11:41:42 UTC Pre-commit check linux-x86_64-release-clang14 for d503a6d has started.
⚪ 2024-09-17 11:41:51 UTC Artifacts will be uploaded here
⚫ 2024-09-17 11:44:21 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 11:46:21 UTC Pre-commit check linux-x86_64-release-clang14 for 774fa4a has started.
⚪ 2024-09-17 11:46:30 UTC Artifacts will be uploaded here
⚪ 2024-09-17 11:49:43 UTC ya make is running...
⚫ 2024-09-17 12:08:12 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 11:47:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 774fa4a has started.
⚪ 2024-09-17 11:48:54 UTC Artifacts will be uploaded here
⚪ 2024-09-17 11:52:46 UTC ya make is running...
⚫ 2024-09-17 12:08:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 11:48:58 UTC Pre-commit check linux-x86_64-release-asan for 774fa4a has started.
⚪ 2024-09-17 11:49:08 UTC Artifacts will be uploaded here
⚪ 2024-09-17 11:52:23 UTC ya make is running...
⚫ 2024-09-17 12:08:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 12:09:42 UTC Pre-commit check linux-x86_64-release-clang14 for 5bd18ea has started.
⚪ 2024-09-17 12:09:52 UTC Artifacts will be uploaded here
⚪ 2024-09-17 12:13:10 UTC ya make is running...
🟢 2024-09-17 12:49:02 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 12:09:42 UTC Pre-commit check linux-x86_64-release-asan for 5bd18ea has started.
⚪ 2024-09-17 12:09:53 UTC Artifacts will be uploaded here
⚪ 2024-09-17 12:13:06 UTC ya make is running...
⚫ 2024-09-17 13:23:46 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 12:12:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5bd18ea has started.
⚪ 2024-09-17 12:13:23 UTC Artifacts will be uploaded here
⚪ 2024-09-17 12:16:38 UTC ya make is running...
⚫ 2024-09-17 13:23:49 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:25:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4686962 has started.
⚪ 2024-09-17 13:26:42 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:30:32 UTC ya make is running...
⚫ 2024-09-17 13:43:28 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:26:51 UTC Pre-commit check linux-x86_64-release-asan for 4686962 has started.
⚪ 2024-09-17 13:26:55 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:30:17 UTC ya make is running...
⚫ 2024-09-17 13:43:27 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:26:52 UTC Pre-commit check linux-x86_64-release-clang14 for 4686962 has started.
⚪ 2024-09-17 13:27:37 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:31:18 UTC ya make is running...
⚫ 2024-09-17 13:43:27 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:44:11 UTC Pre-commit check linux-x86_64-release-clang14 for 8c2be3d has started.
⚪ 2024-09-17 13:44:28 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:47:51 UTC ya make is running...
⚫ 2024-09-17 13:52:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:44:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8c2be3d has started.
⚪ 2024-09-17 13:45:09 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:48:31 UTC ya make is running...
⚫ 2024-09-17 13:52:03 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:45:54 UTC Pre-commit check linux-x86_64-release-asan for 8c2be3d has started.
⚪ 2024-09-17 13:46:04 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:49:15 UTC ya make is running...
⚫ 2024-09-17 13:52:08 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:53:59 UTC Pre-commit check linux-x86_64-release-asan for 93a0436 has started.
⚪ 2024-09-17 13:54:03 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:57:25 UTC ya make is running...
🔴 2024-09-17 15:55:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11878 11640 0 77 49 112

🟢 2024-09-17 15:56:22 UTC Build successful.
🟡 2024-09-17 15:57:00 UTC ydbd size 5.6 GiB changed* by +192.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bdedefb merge: 93a0436 diff diff %
ydbd size 6 045 805 232 Bytes 6 046 002 056 Bytes +192.2 KiB +0.003%
ydbd stripped size 1 513 196 912 Bytes 1 513 254 544 Bytes +56.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:55:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 93a0436 has started.
⚪ 2024-09-17 13:55:31 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:58:43 UTC ya make is running...
🟡 2024-09-17 15:05:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41215 35670 0 6 5439 100

⚪ 2024-09-17 15:10:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 15:21:18 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 15 0 0 1 89

🟢 2024-09-17 15:21:26 UTC Build successful.
🟡 2024-09-17 15:22:10 UTC ydbd size 8.4 GiB changed* by +242.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bdedefb merge: 93a0436 diff diff %
ydbd size 9 030 959 536 Bytes 9 031 208 040 Bytes +242.7 KiB +0.003%
ydbd stripped size 488 765 416 Bytes 488 786 952 Bytes +21.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

⚪ 2024-09-17 13:56:14 UTC Pre-commit check linux-x86_64-release-clang14 for 93a0436 has started.
⚪ 2024-09-17 13:56:17 UTC Artifacts will be uploaded here
⚪ 2024-09-17 13:59:34 UTC ya make is running...
🟢 2024-09-17 14:09:24 UTC Build successful.

@CyberROFL CyberROFL merged commit 0361036 into ydb-platform:main Sep 17, 2024
@CyberROFL CyberROFL deleted the limit-requests branch September 17, 2024 16:27
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 17, 2024
@CyberROFL
Limit inflight cross-database scheme requests in the replication cont…
2f41602 
…roller (ydb-platform#9334)
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 17, 2024
@CyberROFL
Limit inflight cross-database scheme requests in the replication cont…
23826aa 
…roller (ydb-platform#9334)
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 19, 2024
Merged
@shnikd shnikd mentioned this pull request Sep 19, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Sep 24, 2024
Merged
This was referenced Oct 3, 2024
Merged
Merged
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enjection Enjection Enjection approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limit inflight scheme requests from Replication controller

2 participants

@CyberROFL @Enjection