Skip to content

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 17, 2024

Changelog entry

Pre-serialize topic's bootstrap config.

Changelog category

  • Performance improvement

Additional information

...

@CyberROFL CyberROFL linked an issue Sep 17, 2024 that may be closed by this pull request
@CyberROFL CyberROFL marked this pull request as ready for review September 17, 2024 10:23
@CyberROFL CyberROFL requested a review from a team as a code owner September 17, 2024 10:23
@github-actions
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:26:18 UTC Pre-commit check for 0ab130d has started.
2024-09-17 10:29:01 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-17 10:42:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:26:32 UTC Pre-commit check for 0ab130d has started.
2024-09-17 10:29:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-17 10:55:49 UTC Build successful.
2024-09-17 10:56:04 UTC Tests are running...
🔴 2024-09-17 12:54:17 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11166 11098 0 7 25 36

🟡 2024-09-17 12:54:56 UTC ydbd size 5.5 GiB changed* by +166.1 KiB, which is >= 100.0 KiB vs stable-24-3-9-hotfix: Warning

ydbd size dash stable-24-3-9-hotfix: cbd539e merge: 0ab130d diff diff %
ydbd size 5 934 964 576 Bytes 5 935 134 672 Bytes +166.1 KiB +0.003%
ydbd stripped size 1 487 947 488 Bytes 1 487 969 696 Bytes +21.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 10:26:49 UTC Pre-commit check for 0ab130d has started.
2024-09-17 10:29:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-17 11:12:23 UTC Build successful.
2024-09-17 11:12:39 UTC Tests are running...
🔴 2024-09-17 12:40:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15474 14139 0 4 1299 32

🟡 2024-09-17 12:41:19 UTC ydbd size 8.2 GiB changed* by +220.8 KiB, which is >= 100.0 KiB vs stable-24-3-9-hotfix: Warning

ydbd size dash stable-24-3-9-hotfix: cbd539e merge: 0ab130d diff diff %
ydbd size 8 761 399 560 Bytes 8 761 625 672 Bytes +220.8 KiB +0.003%
ydbd stripped size 479 021 512 Bytes 479 026 952 Bytes +5.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) September 17, 2024 12:47
@CyberROFL CyberROFL merged commit 35ed2f2 into ydb-platform:stable-24-3-9-hotfix Sep 17, 2024
@CyberROFL CyberROFL deleted the preserialized-bootstrap-config-24-3-9-hotfix branch September 17, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserialized BootstrapConfig

2 participants