Skip to content

disable warmup for root hive #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vporyadke merged 1 commit into from
Jan 15, 2024
Merged

disable warmup for root hive #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ydb/core/mind/hive/hive_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4163,7 +4163,9 @@ Y_UNIT_TEST_SUITE(THiveTest) {
static const int NUM_TABLETS = NUM_NODES * TABLETS_PER_NODE;

TTestBasicRuntime runtime(NUM_NODES, false);
Setup(runtime, true);
Setup(runtime, true, 1, [](TAppPrepare& app) {
app.HiveConfig.SetWarmUpEnabled(true);
});
const int nodeBase = runtime.GetNodeId(0);
TActorId senderA = runtime.AllocateEdgeActor();
const ui64 hiveTablet = MakeDefaultHiveID(0);
Expand Down
6 changes: 5 additions & 1 deletion ydb/core/mind/hive/tx__load_everything.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ class TTxLoadEverything : public TTransactionBase<THive> {
}

Self->BuildCurrentConfig();
Self->WarmUp = Self->CurrentConfig.GetWarmUpEnabled();
if (Self->CurrentConfig.HasWarmUpEnabled()) {
Self->WarmUp = Self->CurrentConfig.GetWarmUpEnabled();
} else {
Self->WarmUp = Self->CurrentConfig.GetWarmUpEnabled() && !Self->AreWeRootHive();
}

Self->DefaultResourceMetricsAggregates.MaximumCPU.SetWindowSize(TDuration::MilliSeconds(Self->GetMetricsWindowSize()));
Self->DefaultResourceMetricsAggregates.MaximumMemory.SetWindowSize(TDuration::MilliSeconds(Self->GetMetricsWindowSize()));
Expand Down