Skip to content

Conversation

@pashandor789
Copy link
Contributor

@pashandor789 pashandor789 commented Sep 23, 2024

Changelog category

  • Bugfix

Only remove an "item." prefix in variables in the plan if the first character is not alphanum.
We remove the excessive "item." prefix (which is a synthetic variable inside the plan) to clean up the plans.
However, current rules screws up valid variables, such as "lineitem.key"

@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 19:09:08 UTC Pre-commit check linux-x86_64-release-asan for 119fab5 has started.
2024-09-23 19:09:19 UTC Artifacts will be uploaded here
2024-09-23 19:12:17 UTC ya make is running...
🔴 2024-09-23 21:05:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10550 10325 0 44 56 125

🟢 2024-09-23 21:06:14 UTC Build successful.
🟢 2024-09-23 21:06:50 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1002b94 merge: 119fab5 diff diff %
ydbd size 6 079 048 480 Bytes 6 079 048 384 Bytes -96 Bytes -0.000%
ydbd stripped size 1 519 895 600 Bytes 1 519 895 536 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 19:09:12 UTC Pre-commit check linux-x86_64-release-clang14 for 119fab5 has started.
2024-09-23 19:09:21 UTC Artifacts will be uploaded here
2024-09-23 19:12:19 UTC ya make is running...
🟢 2024-09-23 19:18:53 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 19:09:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 119fab5 has started.
2024-09-23 19:09:27 UTC Artifacts will be uploaded here
2024-09-23 19:12:21 UTC ya make is running...
🟡 2024-09-23 20:22:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39742 33930 0 9 5769 34

2024-09-23 20:25:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 20:37:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
359 (only retried tests) 262 0 0 7 90

🟢 2024-09-23 20:37:08 UTC Build successful.
🟢 2024-09-23 20:37:52 UTC ydbd size 8.4 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1002b94 merge: 119fab5 diff diff %
ydbd size 9 070 923 400 Bytes 9 070 923 368 Bytes -32 Bytes -0.000%
ydbd stripped size 490 539 784 Bytes 490 539 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделай описание плз зачем это нужно, в чем заключается фикс, ничего не понятно

@github-actions github-actions bot added bugfix and removed bugfix labels Sep 23, 2024
@pashandor789
Copy link
Contributor Author

Сделай описание плз зачем это нужно, в чем заключается фикс, ничего не понятно

Сделай описание плз зачем это нужно, в чем заключается фикс, ничего не понятно

Да сделал я сделал

@maximyurchuk maximyurchuk requested review from maximyurchuk and removed request for maximyurchuk September 23, 2024 21:04
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 24, 2024
@pavelvelikhov pavelvelikhov changed the title [CLI] bug fix. [CLI] Bugfix: remove item prefix correctly Sep 24, 2024
@pavelvelikhov pavelvelikhov self-requested a review September 24, 2024 06:23
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 24, 2024
@pashandor789 pashandor789 merged commit 922ce5c into ydb-platform:main Sep 24, 2024
@pashandor789 pashandor789 deleted the CLI_228_FIX_228 branch September 24, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants