Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Sep 30, 2024

Changelog entry

groups sorting

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner September 30, 2024 11:10
@adameat adameat enabled auto-merge (squash) September 30, 2024 11:10
@github-actions
Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 11:11:40 UTC Pre-commit check linux-x86_64-release-asan for cdb8519 has started.
2024-09-30 11:11:51 UTC Artifacts will be uploaded here
2024-09-30 11:14:53 UTC ya make is running...
🟡 2024-09-30 13:40:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11874 11609 0 67 74 124

🟢 2024-09-30 13:41:32 UTC Build successful.
🟡 2024-09-30 13:42:10 UTC ydbd size 5.7 GiB changed* by +217.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fbe6aca merge: cdb8519 diff diff %
ydbd size 6 085 233 216 Bytes 6 085 456 096 Bytes +217.7 KiB +0.004%
ydbd stripped size 1 520 350 960 Bytes 1 520 413 680 Bytes +61.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 11:13:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for cdb8519 has started.
2024-09-30 11:14:09 UTC Artifacts will be uploaded here
2024-09-30 11:17:11 UTC ya make is running...
🟡 2024-09-30 12:40:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41240 35667 0 12 5459 102

2024-09-30 12:43:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-30 12:55:09 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 18 0 0 0 92

🟢 2024-09-30 12:55:16 UTC Build successful.
🟡 2024-09-30 12:55:38 UTC ydbd size 2.8 GiB changed* by +142.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fbe6aca merge: cdb8519 diff diff %
ydbd size 3 001 429 136 Bytes 3 001 575 280 Bytes +142.7 KiB +0.005%
ydbd stripped size 477 332 328 Bytes 477 344 552 Bytes +11.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat changed the title Fix group sorting fix group sorting Sep 30, 2024
@adameat adameat merged commit 500c5c7 into ydb-platform:main Sep 30, 2024
@adameat adameat linked an issue Oct 1, 2024 that may be closed by this pull request
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
pashandor789 pushed a commit to pashandor789/ydb that referenced this pull request Oct 1, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat adameat deleted the fix-group-sorting branch November 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sort groups by name in storage/groups and viewer/nodes

2 participants