Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop --sslv3 flag #42

Merged
merged 1 commit into from
Nov 3, 2015
Merged

drop --sslv3 flag #42

merged 1 commit into from
Nov 3, 2015

Conversation

martinlindhe
Copy link
Contributor

(which forced SSL v3), while https://ydns.io/ serves a TLS 1.2 cert, thus breaking the updater

…s a TLS 1.2 cert, thus breaking the updater
@Mikaela
Copy link
Contributor

Mikaela commented Nov 3, 2015

Could you update the commit message or pull request and add "Closes #19" to the end so that issue gets closed when this is merged?

No one should support SSLv3 nowadays, because of POODLE and that probably happened with ydns and updater was forgotten.

@commx
Copy link

commx commented Nov 3, 2015

Thanks for the commit.

Seems like I forgot to modify this script to make sure that it still works, as we've explicitly blacklisted SSLv3 on server-side.

The --sslv3 was added some time ago [#10] by an contributor to ensure that we find a way to support SSL/TLS transport even for cURL versions which are quite old (those who may be older than 8-10+ years). By omitting the --sslv3 switch, cURL will automatically choose the best available protocol version.

Closes #19 too.

@commx commx closed this Nov 3, 2015
@martinlindhe
Copy link
Contributor Author

Merge too? :)

@commx commx reopened this Nov 3, 2015
commx pushed a commit that referenced this pull request Nov 3, 2015
@commx commx merged commit d334f99 into ydns:master Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants