Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drone chinese resources AND Fix error links #264

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Add Drone chinese resources AND Fix error links #264

merged 4 commits into from
Nov 30, 2017

Conversation

khs1994
Copy link
Collaborator

@khs1994 khs1994 commented Nov 30, 2017

Proposed changes (Mandatory)

Add Drone #261

Add chinese resources #200

Fix issues (Optional)

Fix error links

@khs1994 khs1994 merged commit cd776a1 into yeasy:master Nov 30, 2017
@yeasy yeasy self-requested a review November 30, 2017 09:24
@yeasy
Copy link
Owner

yeasy commented Nov 30, 2017

We should strictly review the external ref link before adding.

@khs1994
Copy link
Collaborator Author

khs1994 commented Nov 30, 2017

中文变更日志 作者是 Docker 源码贡献者,权威性可以保证。

100 问 内容解决了新手常见的问题。

Dockerfile 最佳实践 一文中虽有一些翻译的纰漏,但对于英文不太好的新手来说也有一定的参考价值 。

@yeasy
Copy link
Owner

yeasy commented Nov 30, 2017

I would prefer we give the original link first, we can add optional translated link too.
If there are true requirements from the readers, then let’s discuss to find some better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants