Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add SerialBagging classes #60

Merged
merged 1 commit into from
Dec 13, 2020
Merged

ENH: Add SerialBagging classes #60

merged 1 commit into from
Dec 13, 2020

Conversation

richford
Copy link
Collaborator

This PR creates a private module with serial versions of the sklearn.ensemble bagging estimators.

This is needed mostly because I struggle with nested parallelism when using dask.distruted as a parallel backend. In order to expose parallelism at the base estimator level (which is where it usually does the most good for me), I've found that I need meta-estimators and cross-validation functions to be run in serial. This is unnecessary when using the default joblib backends, but becomes necessary when using dask.distributed. If someone can tell me how to fully exploit nested
parallelism when using a dask.distributed backend, I will gladly remove this private module.

@richford richford added effort: medium A medium amount of effort needed to resolve this issue enhancement New feature or request impact: medium A medium amount of effort needed to resolve this issue labels Dec 13, 2020
@richford richford merged commit c62b455 into main Dec 13, 2020
@richford richford deleted the enh/serial-bagging branch December 13, 2020 18:33
richford added a commit that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium A medium amount of effort needed to resolve this issue enhancement New feature or request impact: medium A medium amount of effort needed to resolve this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant