Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allow bundle aggregation and put load_afq_data output into a named_tuple #80

Merged
merged 7 commits into from
Jul 9, 2021
Merged

ENH: Allow bundle aggregation and put load_afq_data output into a named_tuple #80

merged 7 commits into from
Jul 9, 2021

Conversation

richford
Copy link
Collaborator

@richford richford commented Jul 7, 2021 •
edited
Loading

Resolves #78

This PR adds a bundle_agg_func parameter to AFQDataFrameMapper. It's WIP because I haven't yet exposed that functionality as part of load_afq_data.

@richford richford added the enhancement New feature or request label Jul 7, 2021
@richford richford linked an issue Jul 7, 2021 that may be closed by this pull request
The output from load_afq_data is getting pretty busy #81
Closed
@richford richford changed the title WIP ENH: Allow bundle aggregation ENH: Allow bundle aggregation and put load_afq_data output into a named_tuple Jul 7, 2021
@richford
Copy link
Collaborator Author

richford commented Jul 7, 2021

I'm willing to eat the -0.01% reduction in coverage.

@richford richford requested a review from arokem July 8, 2021 18:06
arokem
arokem reviewed Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a slightly different API in mind - see comment.

afqinsight/datasets.py Outdated Show resolved Hide resolved
@arokem
Copy link
Collaborator

arokem commented Jul 9, 2021

LGTM! Merging.

@arokem arokem merged commit d012785 into main Jul 9, 2021
@arokem arokem mentioned this pull request Jul 9, 2021
Merged
richford pushed a commit that referenced this pull request Jul 19, 2021
@arokem
Merge pull request #80 from richford/enh/bundle-agg
4d923be 
ENH: Allow bundle aggregation and put load_afq_data output into a named_tuple
@richford richford deleted the enh/bundle-agg branch August 24, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The output from load_afq_data is getting pretty busy Add a GroupMeanTransformer
2 participants
@richford @arokem