Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enforce_sub_prefix option to AFQDataset and load_afq_data #96

Merged
merged 8 commits into from
Dec 7, 2021
Merged

Add enforce_sub_prefix option to AFQDataset and load_afq_data #96

merged 8 commits into from
Dec 7, 2021

Conversation

richford
Copy link
Collaborator

@richford richford commented Dec 2, 2021

Resolves #94

@richford richford added the enhancement New feature or request label Dec 2, 2021
@richford richford requested a review from arokem December 2, 2021 18:14
@richford
Copy link
Collaborator Author

richford commented Dec 4, 2021

I think this is ready for review @arokem, whenever you get a chance.

arokem
arokem reviewed Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I found a couple of typos, and was wondering whether this could be tested beyond the currently implemented smoke test.

afqinsight/datasets.py Outdated Show resolved Hide resolved
afqinsight/datasets.py Outdated Show resolved Hide resolved
afqinsight/tests/test_datasets.py Show resolved Hide resolved
@richford richford mentioned this pull request Dec 7, 2021
Merged
@richford
Copy link
Collaborator Author

richford commented Dec 7, 2021

I'm going to recommend merging and eating the -0.005% decrease in coverage since the code changes are in datasets.py and the coverage for that file is 100%

@richford richford merged commit 362c9d2 into main Dec 7, 2021
@richford richford deleted the enh/match-sub-ids branch December 7, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match subject identifiers with and without the "sub-" prefix
2 participants
@richford @arokem