ENH: add lower triangular scalars from DTI (could be useful for ML)? #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arokem this might be useful for the final NKI run. |
arokem
reviewed
Aug 3, 2022
| @@ -280,6 +280,24 @@ def dti_fa(dti_tf): | |||
| return dti_tf.fa | |||
|
|
|||
|
|
|||
| @pimms.calc("dti_lt0", "dti_lt1", "dti_lt2", "dti_lt3", "dti_lt4", "dti_lt5") | |||
There was a problem hiding this comment.
Do we want dki_lt elements as well? I believe there are 15 elements in DKI.
And relatedly, we often calculate FA/MD from DKI, when that's doable (i.e., when there are multiple non-zero b-values). Do we want to be able to extract the six DTI elements from DKI?
Agreed! And the DKI questions do not pertain to that, so we could merge this as-is for that, and then come back to deal with those questions later on. |
|
@arokem can we merge this and do DKI in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can already be calculated from our derivatives, but now they are formally added to the task system.
Also adds a change for tract profile calculation that should significantly speed it up.