-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] don't resample subject-space ROIs unless user provides something #919
Conversation
845f2e2
to
589dab7
Compare
Do we need to add tests to keep this from breaking? |
I think we should. do we have some subject-space ROIs for this subject we could use? |
There's a functionally-defined LV1 for the Stanford HARDI dataset here: https://searchworks.stanford.edu/view/ng782rw8378 This notebook shows how it could be downloaded: https://github.com/arokem/visual-white-matter/blob/master/download-data.ipynb |
What does LV1 mean? lower primary visual cortex? Than should the other ROI between the LGN for the bundle? |
It's left visual cortex. Maybe we can find another ROI in the aparc reduced file that is also in that same collection? |
589dab7
to
d3bb066
Compare
@arokem I brought in your changes from the PR in my repository. This is now ready for review |
234b2de
to
adb2473
Compare
@arokem this is ready for review / merge |
Looks good. At some point we should also make an example of the subject-space ROI functionality for endpoints, since this is a pretty cool use-case. |
Currently I think subject-space ROIs are resampled to MNI, which is a bug.
It used to say:
"
If None, the template will be overriden when passed to
an API class."
But I see no evidence that I actually implemented this.