-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase inclusion tolerance for pAF; add suffix for cmd_outputs #921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this feature would be used, so maybe adding an example might help.
@@ -510,9 +511,12 @@ def cmd_outputs(self, cmd="rm", dependent_on=None, exceptions=[]): | |||
exceptions : list of str | |||
Name outputs that the command should not be applied to. | |||
Default: [] | |||
suffix : str | |||
Parts of command that are used after the filename. | |||
Default: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to provide an example here.
@@ -258,6 +258,7 @@ def _gen(self, bundle_name): | |||
roi_dict['space'] = 'template' | |||
roi_dict['start'] = self.templates[bundle_name + "_start"] | |||
roi_dict['end'] = self.templates[bundle_name + "_end"] | |||
roi_dict["inc_addtol"] = [4, 0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other place I found inc_addtol
in our code base is here:
Line 166 in 288e5a4
bundle_dict["ARC_R"]["inc_addtol"] = [3, 3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in fact here: https://github.com/yeatmanlab/pyAFQ/blob/master/AFQ/segmentation.py#L485-L489.
Should also go into bundle_dict.rst documentation.
@arokem ready for review / merge |
also adds suffix for cmd_outputs