Increase inclusion tolerance for pAF; add suffix for cmd_outputs #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Nov 2, 2022
| @@ -510,9 +511,12 @@ def cmd_outputs(self, cmd="rm", dependent_on=None, exceptions=[]): | |||
| exceptions : list of str | |||
| Name outputs that the command should not be applied to. | |||
| Default: [] | |||
| suffix : str | |||
| Parts of command that are used after the filename. | |||
| Default: "" | |||
There was a problem hiding this comment.
Might be good to provide an example here.
| @@ -258,6 +258,7 @@ def _gen(self, bundle_name): | |||
| roi_dict['space'] = 'template' | |||
| roi_dict['start'] = self.templates[bundle_name + "_start"] | |||
| roi_dict['end'] = self.templates[bundle_name + "_end"] | |||
| roi_dict["inc_addtol"] = [4, 0] | |||
There was a problem hiding this comment.
The only other place I found inc_addtol in our code base is here:
Line 166 in 288e5a4
There was a problem hiding this comment.
It is in fact here: https://github.com/yeatmanlab/pyAFQ/blob/master/AFQ/segmentation.py#L485-L489.
Should also go into bundle_dict.rst documentation.
36000
changed the title
|
@arokem ready for review / merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds suffix for cmd_outputs