[FIX] fix a small bug in the curvature code #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to test this code with a test that fails without this fix? |
|
I think this change is very minor and not worth writing a test over, however I did just add a test of the curvature system as called through the Segmentation object, which tests this code more generally. Previously only the sl_curve and sl_curve_dist functions were tested individually, not in the context of the Segmentation object. |
arokem
reviewed
Aug 23, 2023
|
I have no idea why this test is not working, as it seems to pass locally |
|
it appears to be because I was using an older version of dipy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.