Bc 246 chiu migrate sign up #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeezick
reviewed
Aug 31, 2022
| font-size: 12px; | ||
| font-style: italic; | ||
| .SingleActionButton { | ||
| background-color: red; |
There was a problem hiding this comment.
what's this class' intent? i don't see a use case for this on the figma
There was a problem hiding this comment.
left that in by accident. I believe it came with the old css file so I was trying to locate it to see what it was doing.
yeezick
requested changes
Aug 31, 2022
There was a problem hiding this comment.
@chiumz9 so far so good! Everything looks fine, code looks clean. Only comments are about styling:
- the font you have is much thinner than on the figma, clicking on the figma element should give you the right weights and stuff
- a lot of gap between labels and their inputs, i recommend shortening this distance but keeping the distance between the inputs above it. this article will show you how to measure distance on figma
last thing I would recommend is to run git pull origin refactor/react-migration to deal with any conflicts with this file
Ping me when these are done, merging won't be long after!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Corrected texts to match Figma
-Margins weren't listed in Figma so I gauged it
-Added some shadows to match Figma
Comments
-Single Action button doesn't match color in Figma. Black vs Darkgrey