Bc 237 migrate edit profile #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeezick
reviewed
Sep 22, 2022
yeezick
reviewed
Sep 22, 2022
| @@ -70,7 +80,7 @@ const AboutUser = () => { | |||
|
|
|||
| return ( | |||
| <div className="about-user"> | |||
| <Form formData={userForm} formState={[userInfo, setUserInfo, handleUserUpdate]} /> | |||
| <EditProfileForm formData={userForm} formState={[userInfo, setUserInfo, handleUserUpdate]} /> | |||
There was a problem hiding this comment.
Let's relieve ourselves from the need of a custom-input-vending component. A form from scratch is going to be much easier to go back and update and ultimately gives us more control vs. a headache.
Don't build another component, you can build the form directly in here.
yeezick
requested changes
Sep 22, 2022
There was a problem hiding this comment.
Besides the comments above, let's also:
- make it so that clicking anywhere in the role checkboxes will activate the check.
- text inputs should have a margin of 10 - 24 - 10 - 10 (top, right, left, bottom)
Besides that everything else looked great! Good work! Love what you did with the checkboxes and character count
|
Changes disscued have been corrected. Ready to be reviewed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged some elements, added the character count feature to match the figma. Used UserProfile as a reference to some styling.