Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hangman to harness immutability, object orientation, old&plain cli #4

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Refactor hangman to harness immutability, object orientation, old&plain cli #4

wants to merge 21 commits into from

Commits on May 22, 2017

  1. Class to encapsulate a secret phrase to be uncovered

    @fejnartal
    fejnartal committed May 22, 2017
    Configuration menu
    Copy the full SHA
    e485897 View commit details
    Browse the repository at this point in the history

  2. Guesses represent progressive, incremental knowledge about the solution.

    fejnartal committed May 22, 2017
    Configuration menu
    Copy the full SHA
    1f297b2 View commit details
    Browse the repository at this point in the history

  3. Modeling mistakes counter

    @fejnartal
    fejnartal committed May 22, 2017
    Configuration menu
    Copy the full SHA
    cbf06b0 View commit details
    Browse the repository at this point in the history

  4. Hangman game coordinating class.

    @fejnartal
    fejnartal committed May 22, 2017
    Configuration menu
    Copy the full SHA
    d9ed4eb View commit details
    Browse the repository at this point in the history

  5. Random hardcoded vocabulary as in the original code.

    @fejnartal
    fejnartal committed May 22, 2017
    Configuration menu
    Copy the full SHA
    f8fc70b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. Number of allowed mistakes should be determined by SecretPhrase

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    9b7ce20 View commit details
    Browse the repository at this point in the history

  2. Bugfix: mistake on first round were not counted.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    5ac865c View commit details
    Browse the repository at this point in the history

  3. Added final touches to Hangman game class. Game status, resolution, etc

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    cd78d45 View commit details
    Browse the repository at this point in the history

  4. Bugfix: Repeating a known letter caused it to be hidden again.

    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    f9a23de View commit details
    Browse the repository at this point in the history

  5. Bugfix: Win condition was never satisfied. Expose total allowed mistakes

    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    84ee240 View commit details
    Browse the repository at this point in the history

  6. Simple CLI interface. 

    Possible future improvements.
Ascii animation?
Improved SecretProviders?
Multilanguage support?
    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    fe65ea1 View commit details
    Browse the repository at this point in the history

  7. Delete broken test.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    8a677ba View commit details
    Browse the repository at this point in the history

  8. Run Eclipse autoformatter to standardize whitespace, etc.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    8e274f1 View commit details
    Browse the repository at this point in the history

  9. Display total number of round at the end of the game.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    c1c087c View commit details
    Browse the repository at this point in the history

  10. Changed the design of Hangman class to be fully immutable. 

    Handle state by method parameters (receive previous round as method
argument)
    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    002b4d1 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #2 from yegor256/master 

    Sync changes from original repo
    @fejnartal
    fejnartal authored May 23, 2017
    Configuration menu
    Copy the full SHA
    4496b4a View commit details
    Browse the repository at this point in the history

  12. Separate Round and Guess as two different Classes. 

    Encapsulate NULL character manipulation inside Guess class.
Encapsulate Guess combination strategy inside Guess class.

Future work:
Completely hide the public final knownText. Implement a better strategy
to check if some Guess contains the full secretPhrase already.
    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    facbfe2 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'feature/object_oriented' of https://github.com/fejnarta… 

    …l/hangman.git into feature/object_oriented
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    8ead7b4 View commit details
    Browse the repository at this point in the history

  14. Polished Guess combination API & some renaming for the sake of clarity.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    174f0ab View commit details
    Browse the repository at this point in the history

  15. Restructure packages to better represent relationship between classes.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    cc113ff View commit details
    Browse the repository at this point in the history

  16. Remove unnecessary variable.

    @fejnartal
    fejnartal committed May 23, 2017
    Configuration menu
    Copy the full SHA
    fcb7603 View commit details
    Browse the repository at this point in the history