Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PsLinkedin #12

Closed
yegor256 opened this issue Mar 4, 2015 · 22 comments
Closed

PsLinkedin #12

yegor256 opened this issue Mar 4, 2015 · 22 comments

Comments

@yegor256
Copy link
Owner

yegor256 commented Mar 4, 2015

Let's create a new Pass for LinkedIn authentication, call it PsLinkedin, similar to PsGithub we already have

@davvd
Copy link

davvd commented Mar 12, 2015

@yegor256 thanks, I added the "bug" tag

@yegor256
Copy link
Owner Author

@davvd assign this to me

@davvd
Copy link

davvd commented Mar 14, 2015

@davvd assign this to me

@yegor256 of course, the task is yours, go ahead

@davvd
Copy link

davvd commented Mar 14, 2015

@davvd assign this to me

@yegor256 in the future, try to avoid assigning yourself to your own tasks

@davvd
Copy link

davvd commented Mar 15, 2015

@yegor256 thanks for the report, I topped your acc for 15 mins, payment ID 000-67068c64

@yegor256
Copy link
Owner Author

yegor256 commented Apr 3, 2015

@davvd assign someone else pls

@yegor256
Copy link
Owner Author

yegor256 commented Apr 3, 2015

@davvd
Copy link

davvd commented Apr 3, 2015

@davvd assign someone else pls

@yegor256 got it, someone else will be assigned soon

@davvd davvd removed the @yegor256 label Apr 3, 2015
@davvd
Copy link

davvd commented Apr 3, 2015

@dmzaytsev please go ahead with this task, it's yours

dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 3, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 4, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 4, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 4, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 4, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 5, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 5, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 5, 2015
@dmzaytsev
Copy link
Contributor

@yegor256 the PR #116 merged
take a look at the changes, if you accept it, close the task please, thank you

@yegor256
Copy link
Owner Author

yegor256 commented Apr 5, 2015

thanks!

@yegor256 yegor256 closed this as completed Apr 5, 2015
@davvd
Copy link

davvd commented Apr 6, 2015

there is a puzzle in this code 12-159d303e, we'll resolve it later

@davvd
Copy link

davvd commented Apr 7, 2015

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@elenavolokhova
Copy link

@yegor256 @davvd Please don't forget to address your comments.

@elenavolokhova
Copy link

@dmzaytsev

davvd commented 4 days ago
there is a puzzle in this code 12-159d303e, we'll resolve it later

yegor256 commented 5 days ago
thanks!

yegor256 commented 8 days ago
we can use this class as an example: https://github.com/yegor256/rexsl/blob/master/src/main/java/com/rexsl/page/auth/LinkedIn.java

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

As far as you are the performer of this ticket you are responsible for its quality. Please make sure that everyone follows this rule in your tickets in the future.

Please confirm that everything is clear and you have no questions regarding this approach.

@dmzaytsev
Copy link
Contributor

@elenavolokhova I confirm

@dmzaytsev
Copy link
Contributor

@davvd @yegor256 According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

please fix your messages, thank you

@elenavolokhova
Copy link

@dmzaytsev Your confirmation is enough here. Let's prevent this in the future. Thank you!

@elenavolokhova
Copy link

@davvd Ticket passed QA review. Quality is acceptable.

@davvd
Copy link

davvd commented Apr 15, 2015

@davvd Ticket passed QA review. Quality is acceptable.

@elenavolokhova thanks for the QA review, we'll work better next time

@davvd
Copy link

davvd commented Apr 15, 2015

@dmzaytsev 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 55479416

38 mins added to your account (payment number 55479447), many thanks for your contribution! 65 hours and 53 mins spent here.

the bonus for fast delivery (age=2970)

+38 added to your rating, current score is: +392

@davvd
Copy link

davvd commented Jun 10, 2015

@yegor256 the last puzzle 12-159d303e/#158 originated from here solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants