RqHref.Base reads first line of header without checking format

[HDouss]

org.takes.rq.RqHref.Base just reads first header and takes second element after space splitting :
this.head().iterator().next().split(" ", 3)[1]
It should check if the header format satisfies HTTP specifications.

---

- `445-5323c196`/#473 (by Vladimir Maximenko)

[davvd]

@yegor256 take a look at this issue please and dispatch it somehow, see par.21

[yegor256]

@HDouss seems to be a valid bug, thanks

[davvd]

@HDouss attached this issue to milestone "1.0" (let me know if this is wrong)

[davvd]

@HDouss thanks for reporting! I topped your account for 15 mins, transaction 71676136

[davvd]

@Happy-Neko could you please pick this up? This article explains how we work. Any technical questions you may ask right here

The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

[davvd]

@HDouss once 445-5323c196/#473 puzzle is resolved (later, in another ticket), this ticket will be fully complete

[HDouss]

@davvd I should anyway close this issue, right ?

[HDouss]

@Happy-Neko The pattern used assume that a "third part" of the request line is optional. I am not sure it is the case according to the specifications. The current implemented pattern will accept request lines like : GET HTTP/1.1 or GET /

[ikarsokolov]

@HDouss Protocol part is required per HTTP 1.1 specs. It is optional if we want to maintain backward compatibility with HTTP 1.0.

[HDouss]

@Happy-Neko Ok. Make sense.

[HDouss]

@davvd I will close the issue as the PR is merged and accepted.

[HDouss]

@Happy-Neko Please make a reference to the PR id.

[ikarsokolov]

@HDouss issue was fixed in PR #466

[HDouss]

@Happy-Neko Thanks !

[davvd]

@ypshenychka please, check this issue for QA compliance, as per par.24

[ypshenychka]

@davvd Quality is good here.

[davvd]

@davvd Quality is good here.

@ypshenychka thank you

[davvd]

@Happy-Neko 10 mins was added to the account of @ypshenychka (for QA review), in transaction 72638957; thanks, I just added 30 mins to your account, payment 72640289, 125 hours and 51 mins spent; added +30 to your rating, now it is equal to +30

[davvd]

@HDouss last puzzled solved 445-5323c196/#473