Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqHref.java:83-86: RqMethod already validates Request-Line and... #473

Closed
davvd opened this issue Dec 19, 2015 · 15 comments
Closed

RqHref.java:83-86: RqMethod already validates Request-Line and... #473

davvd opened this issue Dec 19, 2015 · 15 comments

Comments

@davvd
Copy link

davvd commented Dec 19, 2015

Puzzle 445-5323c196 in src/main/java/org/takes/rq/RqHref.java:83-86 has to be resolved: RqMethod already validates Request-Line and extracts HTTP Method from it. We should extract all important information from Request-Line (HTTP method, URI and HTTP version) in one place to enforce DRY principle.... The puzzle was created by Ikar Sokolov on 15-Dec-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented Dec 19, 2015

@xupyprmv please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have. Budget here is 30 mins (keep this principle in mind)

@davvd
Copy link
Author

davvd commented Dec 19, 2015

@yegor256 there is no milestone yet, so I set it to 1.0

@davvd davvd added this to the 1.0 milestone Dec 19, 2015
xupyprmv added a commit to xupyprmv/takes that referenced this issue Dec 26, 2015
xupyprmv added a commit to xupyprmv/takes that referenced this issue Dec 28, 2015
@davvd
Copy link
Author

davvd commented Jan 3, 2016

@xupyprmv you're holding this ticket for 15 days already. If it is not finished (and closed) in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle (this article should help if you're stuck). as a reminder, don't forget to remove the @todo puzzle from the source code. -30 added to your rating, at the moment it is: -30

@xupyprmv
Copy link
Contributor

xupyprmv commented Jan 3, 2016

@davvd The PR #484 is on CR by @yegor256. It's not my fault.

xupyprmv added a commit to xupyprmv/takes that referenced this issue Jan 4, 2016
@yegor256
Copy link
Owner

yegor256 commented Jan 4, 2016

@xupyprmv everything is your fault, until the task is done. this is our philosophy. when you see that the task is delayed, do something about it. ask @davvd, or me, but don't just wait. we're not managing you, you're managing yourself. I would recommend to read the policy again: http://at.teamed.io/policy

xupyprmv added a commit to xupyprmv/takes that referenced this issue Jan 4, 2016
@davvd
Copy link
Author

davvd commented Jan 4, 2016

@davvd The PR #484 is on CR by @yegor256. It's not my fault.

@xupyprmv everything is your fault while you're working with a ticket, see http://at.teamed.io/policy.html#7

xupyprmv added a commit to xupyprmv/takes that referenced this issue Jan 4, 2016
@xupyprmv
Copy link
Contributor

xupyprmv commented Jan 5, 2016

@davvd I need more time for that ticket. PR #484 is on CR and it will be merged soon, because last CR result doesn't contain any significant remarks.

@xupyprmv
Copy link
Contributor

xupyprmv commented Jan 6, 2016

@davvd This issue is fixed. PR #484 was merged. Please close this ticket if you have no more remarks.

@davvd
Copy link
Author

davvd commented Jan 6, 2016

@davvd I need more time for that ticket. PR #484 is on CR and it will be merged soon, because last CR result doesn't contain any significant remarks.

@xupyprmv agreed, take your time

@davvd
Copy link
Author

davvd commented Jan 6, 2016

@davvd This issue is fixed. PR #484 was merged. Please close this ticket if you have no more remarks.

@xupyprmv sure, will do right after the next deployment cycle

@davvd
Copy link
Author

davvd commented Jan 8, 2016

@yegor256 The task is closed, thanks everybody

@davvd davvd closed this as completed Jan 8, 2016
@davvd
Copy link
Author

davvd commented Jan 8, 2016

@ypshenychka please, help us to evaluate quality here, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Jan 9, 2016

@davvd Quality is good.

@ypshenychka thank you

@davvd
Copy link
Author

davvd commented Jan 9, 2016

@xupyprmv I added 10 mins to @ypshenychka (for QA review) in transaction 74072046; Much appreciated! 30 mins was added to your account, payment ID AP-3SK1209573502924F, time spent is 458 hours and 56 mins; added +30 to your rating, now it is equal to +15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants