Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqChunkTest.java:40-43: Implement reading chunked message body... #544

Closed
davvd opened this issue Jan 24, 2016 · 13 comments
Closed

RqChunkTest.java:40-43: Implement reading chunked message body... #544

davvd opened this issue Jan 24, 2016 · 13 comments
Milestone

Comments

@davvd
Copy link

davvd commented Jan 24, 2016

Puzzle 438-dcc4d707 in src/test/java/org/takes/rq/RqChunkTest.java:40-43 has to be resolved: Implement reading chunked message body in {@link RqChunk} class to pass the tests. The request body should be treated as a serie of chunks and be capped to the chunks sizes sum.... The puzzle was created by HDouss on 27-Dec-2015.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Jan 24, 2016

@alexey-krylov could you please pick this up? This article explains how we work. Any technical questions you may ask right here... The budget of this issue is 45 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@davvd davvd added IMP labels Jan 24, 2016
@davvd
Copy link
Author

davvd commented Jan 24, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@davvd davvd added this to the 1.0 milestone Jan 24, 2016
@alexey-krylov
Copy link

@davvd ok, i take this

@davvd
Copy link
Author

davvd commented Jan 26, 2016

@davvd ok, i take this

@alexey-krylov OK

@davvd
Copy link
Author

davvd commented Jan 28, 2016

@xupyprmv please proceed, it's yours

@xupyprmv
Copy link
Contributor

@davvd I need more time here. My PR was already approved and waits for final deploy.

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@davvd I need more time here. My PR was already approved and waits for final deploy.

@xupyprmv of course, thanks for letting me know, take your time

xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 16, 2016
xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 20, 2016
xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 25, 2016
@xupyprmv
Copy link
Contributor

@davvd PR #559 was merged. Please, close this ticket.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 Thanks, closing it now.

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@elenavolokhova please, help us to evaluate quality here, as per par.24

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Looks good!

@elenavolokhova thanks for the review

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@xupyprmv just added 10 mins to @elenavolokhova (for QA), payment ID is 78670787

45 mins added to your account (payment number AP-2KX055396L939714J), many thanks for your contribution! 711 hours and 34 mins spent here.

+45 added to your rating, at the moment it is: +180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants