Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CapInputStream.java:37-40: CapInputStream should delegate all standard... #575

Closed
davvd opened this issue Feb 5, 2016 · 11 comments
Closed

CapInputStream.java:37-40: CapInputStream should delegate all standard... #575

davvd opened this issue Feb 5, 2016 · 11 comments
Labels
30 mins
Milestone
1.0

Comments

@davvd
Copy link

davvd commented Feb 5, 2016

Puzzle 254-d68bc52e in src/main/java/org/takes/rq/CapInputStream.java:37-40 has to be resolved: CapInputStream should delegate all standard InputStream calls to it's origin. It's very important in context of closing stream - right code should close the stream but default InputStream implementation just throws IOException... The puzzle was created by Andrey Eliseev on 22-Jan-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.
@davvd
Copy link
Author

davvd commented Feb 5, 2016

@yegor256 milestone set to 1.0 (correct me if I am wrong)

@davvd davvd added this to the 1.0 milestone Feb 5, 2016
@davvd
Copy link
Author

davvd commented Feb 29, 2016

@original-brownbear please go ahead with this task, it's yours

original-brownbear added a commit to original-brownbear/takes that referenced this issue Mar 1, 2016
@original-brownbear
yegor256#575 implement close and skip method on CapinputStream
3b35a7f
original-brownbear added a commit to original-brownbear/takes that referenced this issue Mar 1, 2016
@original-brownbear
yegor256#575 added tests for implemention of close and skip method on…
4d3c59a 
… CapinputStream
original-brownbear added a commit to original-brownbear/takes that referenced this issue Mar 1, 2016
@original-brownbear
yegor256#575 removed Puzzle
79a8d7c
@original-brownbear original-brownbear mentioned this issue Mar 1, 2016
Merged
@original-brownbear
Copy link
Contributor

@davvd PR #634 created :)

@davvd
Copy link
Author

davvd commented Mar 1, 2016

@davvd PR #634 created :)

@original-brownbear thanks for that

original-brownbear added a commit to original-brownbear/takes that referenced this issue Mar 1, 2016
@original-brownbear
yegor256#575 fixed 2 style issues and exception type in tests from CR
41af769
@original-brownbear
Copy link
Contributor

@davvd fix merged, can you please close this ? :)

@original-brownbear
Copy link
Contributor

@davvd ping :)

@davvd davvd closed this as completed Mar 4, 2016
@davvd
Copy link
Author

davvd commented Mar 4, 2016

@yegor256 Closing this issue now...

@davvd
Copy link
Author

davvd commented Mar 4, 2016

@ypshenychka please, review this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Mar 4, 2016

@davvd Quality is good.

@ypshenychka thanks!

@davvd
Copy link
Author

davvd commented Mar 4, 2016

@original-brownbear paied 10 mins to @ypshenychka for QA review (payment ID is 79317218)

Thanks a lot, I just topped your account for 38 mins, transaction ID AP-5BD63918RA734602U, total time was 67 hours and 42 mins

there is a bonus for fast delivery (m=4062)

added +38 to your rating, now it is equal to +632

@dmzaytsev dmzaytsev mentioned this issue Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@davvd @original-brownbear @ypshenychka