Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Href.java:76-80: Href ctor. According to new... #588

Closed
davvd opened this issue Feb 10, 2016 · 22 comments
Closed

Href.java:76-80: Href ctor. According to new... #588

davvd opened this issue Feb 10, 2016 · 22 comments

Comments

@davvd
Copy link

davvd commented Feb 10, 2016

Puzzle 558-d5ffb2ba in src/main/java/org/takes/misc/Href.java:76-80 has to be resolved: Href ctor. According to new qulice version, constructor must contain only variables initialization and other constructor calls. Refactor code according to that rule and remove ConstructorOnlyInitializesOrCallOtherConstructors warning suppression.... The puzzle was created by Maksimenko Vladimir on 7-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@essobedo it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket; The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@essobedo
Copy link
Contributor

@davvd the PR is ready to be reviewed thx in advance

@davvd
Copy link
Author

davvd commented Feb 14, 2016

@davvd the PR is ready to be reviewed thx in advance

@essobedo OK

@essobedo
Copy link
Contributor

@davvd The PR has been merged, could you please close the ticket and proceed with the QA. Thank you in advance.

@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

3 similar comments
@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 I'm closing the issue...

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@essobedo
According to our quality rules:

Some of ticket messages must mention all pull requests where the problem was actually fixed.

There is no link to related PR in comments. Please fix this issue and follow this rule in your tickets in the future.

@essobedo
Copy link
Contributor

@elenavolokhova Fixed, thanks for the feedback

@elenavolokhova
Copy link

@essobedo Thanks!

@elenavolokhova
Copy link

@davvd Quality is acceptable here.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Quality is acceptable here.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@essobedo
Copy link
Contributor

@davvd everything is ok here could you please proceed?

1 similar comment
@essobedo
Copy link
Contributor

@davvd everything is ok here could you please proceed?

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@essobedo paied 10 mins to @elenavolokhova for QA review (payment ID is 79016796)... Thanks for your contribution, 30 mins was added to your account, payment ID is 79016828, 397 hours and 57 mins spent total... +30 added to your rating, at the moment it is: +255

@essobedo
Copy link
Contributor

@davvd thank you very much!

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@davvd everything is ok here could you please proceed?

@essobedo OK

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@davvd thank you very much!

@essobedo you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants