Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old qulice is being used #530

Closed
krzyk opened this issue Jan 21, 2016 · 14 comments
Closed

Old qulice is being used #530

krzyk opened this issue Jan 21, 2016 · 14 comments

Comments

@krzyk
Copy link
Contributor

krzyk commented Jan 21, 2016

Right now takes project uses qulice from jcab-parent, which is 0.14, but the newest one is 0.15.4.
This new release comes with new checks that can help with the review process (e.g. CascadingIndentationCheck or NonStaticMethodCheck).


- ~~`530-0ac0fcef`/#558~~ (by Vladimir Maximenko) - ~~`558-ffd45315`/#584~~ (by Nicolas FILOTTO) - ~~`558-4ea33ea6`/#604~~ (by Vladimir Maximenko) - ~~`558-7db66253`/#595~~ (by Sebin George) - ~~`558-b4a12ea6`/#589~~ (by Nicolas FILOTTO) - ~~`558-12fc4eff`/#606~~ (by Dalí Freire Dias dos Santos) - ~~`558-7c5810e9`/#598~~ (by Sebin George) - ~~`558-e98f4792`/#586~~ (by Nicolas FILOTTO) - ~~`558-d5ffb2ba`/#588~~ (by Nicolas FILOTTO) - ~~`558-79259f7e`/#602~~ (by Vladimir Maximenko) - ~~`558-afc1c081`/#594~~ (by Dalí Freire Dias dos Santos) - `558-7b985928`/#600 (by Vladimir Maximenko)
@yegor256 yegor256 added the bug label Jan 21, 2016
@davvd
Copy link

davvd commented Jan 21, 2016

@krzyk I will find a developer for the task soon...

@davvd
Copy link

davvd commented Jan 21, 2016

@krzyk I set milestone here to 1.0, let me know if it is wrong

@davvd davvd added this to the 1.0 milestone Jan 21, 2016
@davvd
Copy link

davvd commented Jan 21, 2016

@exper0 please proceed, it's yours

@davvd
Copy link

davvd commented Jan 21, 2016

@krzyk thank you for reporting this, I added 15 mins to your acc, transaction 75203237

@exper0
Copy link
Contributor

exper0 commented Jan 21, 2016

@krzyk do you think we need just to update version of qulice and leave version of jcabi-parent as is?

@krzyk
Copy link
Contributor Author

krzyk commented Jan 21, 2016

@exper0 you can report this upgrade to jcabi-parent, but qulice will always be ahead, so I would add version here. Waiting for parent will add unnecessary overhead.

@exper0
Copy link
Contributor

exper0 commented Jan 29, 2016

@krzyk it's done in PR #535(merged). Please close the ticket

@krzyk
Copy link
Contributor Author

krzyk commented Jan 30, 2016

@exper0 thanks

@davvd
Copy link

davvd commented Jan 31, 2016

@krzyk once 530-0ac0fcef/#558 puzzle is resolved (later, in another ticket), this ticket will be fully complete

@davvd
Copy link

davvd commented Jan 31, 2016

@ypshenychka please, review this task for compliance with our quality rules

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link

davvd commented Jan 31, 2016

@davvd Quality is good.

@ypshenychka many thanks

@davvd
Copy link

davvd commented Jan 31, 2016

@exper0 10 mins was added to the account of @ypshenychka (for QA review), in transaction 75966262. thanks, I just added 30 mins to your account, payment AP-2KJ3625987040821D, 207 hours and 49 mins spent. +30 to your rating, your total score is +633

@davvd
Copy link

davvd commented Apr 22, 2016

@krzyk the last puzzle 558-7b985928/#600 originated from here solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants