Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqMultipart.java:131-135: Base ctor. According to new... #594

Closed
davvd opened this issue Feb 11, 2016 · 20 comments
Closed

RqMultipart.java:131-135: Base ctor. According to new... #594

davvd opened this issue Feb 11, 2016 · 20 comments

Comments

@davvd
Copy link

davvd commented Feb 11, 2016

Puzzle 558-afc1c081 in src/main/java/org/takes/rq/RqMultipart.java:131-135 has to be resolved: Base ctor. According to new qulice version, constructor must contain only variables initialization and other constructor calls. Refactor code according to that rule and remove ConstructorOnlyInitializesOrCallOtherConstructors warning suppression.... The puzzle was created by Maksimenko Vladimir on 7-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 11, 2016

@2686747 it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket. Task's budget is 30 mins (see this for explanation)

@davvd
Copy link
Author

davvd commented Feb 11, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@davvd davvd added this to the 1.0 milestone Feb 11, 2016
@2686747
Copy link

2686747 commented Feb 11, 2016

@davvd the PR is ready to be reviewed thx in advance

@davvd
Copy link
Author

davvd commented Feb 13, 2016

@davvd the PR is ready to be reviewed thx in advance

@2686747 OK thanks

@2686747
Copy link

2686747 commented Feb 20, 2016

@davvd Can we close this?

@davvd
Copy link
Author

davvd commented Feb 27, 2016

@2686747 the task is your hands for the last 15 days.. keep in mind that if it's not closed in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck; do not forget that the ticket will be closed once the @todo puzzle is removed from the code, in master branch; added -30 to your rating, now it is equal to -30

@2686747
Copy link

2686747 commented Feb 27, 2016

@davvd 9 days ago i fixed all issues and there (#603) was a merge/confirm request. 7 days ago i asked you for closing. I missed something?

2686747 added a commit to 2686747/takes that referenced this issue Feb 28, 2016
2686747 added a commit to 2686747/takes that referenced this issue Feb 28, 2016
@2686747
Copy link

2686747 commented Feb 29, 2016

@davvd #603 is done, need some time for confirmation.

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@davvd #603 is done, need some time for confirmation.

@2686747 thanks

@davvd
Copy link
Author

davvd commented Mar 2, 2016

@2686747 you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle. -60 added to your rating, current score is: -37

@davvd davvd removed the @2686747 label Mar 2, 2016
@davvd
Copy link
Author

davvd commented Mar 2, 2016

@dalifreire the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here

The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

dalifreire added a commit to dalifreire/takes that referenced this issue Mar 3, 2016
Solving puzzle 558-afc1c081 in
src/main/java/org/takes/rq/RqMultipart.java:131-135
@dalifreire
Copy link
Contributor

@davvd Thanks. Please, see PR #641.

@davvd
Copy link
Author

davvd commented Mar 4, 2016

@davvd Thanks. Please, see PR #641.

@dalifreire I will take a look, thanks

@dalifreire
Copy link
Contributor

@davvd PR #641 merged, could you close this issue?

@dalifreire
Copy link
Contributor

@davvd Ping... :)

@davvd
Copy link
Author

davvd commented Mar 10, 2016

@yegor256 Closed, done, thanks all

@davvd davvd closed this as completed Mar 10, 2016
@davvd
Copy link
Author

davvd commented Mar 10, 2016

@ypshenychka please, check this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good here.

@davvd
Copy link
Author

davvd commented Mar 10, 2016

@davvd Quality is good here.

@ypshenychka thanks for the review and a good remark

@davvd
Copy link
Author

davvd commented Mar 10, 2016

@dalifreire added 10 mins to @ypshenychka, for QA review, payment code is 79944182

30 mins sent to your balance (ID 79944185), many thanks! It took 137 hours and 14 mins.

+30 to your rating, your total score is +165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants