#594 RqMultipart.java - Removing the warning suppression (PMD.ConstructorOnlyInitializesOrCallOtherConstructors) #641
Conversation
Solving puzzle 558-afc1c081 in src/main/java/org/takes/rq/RqMultipart.java:131-135
|
@davvd Could you find someone to review it? |
|
@dalifreire Thanks, let me find someone who can review this pull request |
|
@krzyk it's yours,please review |
|
@dalifreire please provide a better description of the PR, write what you did |
|
@dalifreire same for the PR title, saying that you solved some bug/todo ID is not enough, PR title should be a short description of the work, and the description should be more elaborate information |
dalifreire
changed the title
dalifreire
changed the title
|
@krzyk Please, could you take a look again? |
| // @checkstyle MagicNumberCheck (1 line) | ||
| Math.min(8192, stream.available()) | ||
| ); | ||
| this.body = Base.body(req); |
There was a problem hiding this comment.
@dalifreire making a static method is a workaround not a solution. Here you could store the stream as a field and create Channel in requests method and pass the created variable to copy and make.
|
@dalifreire added one more comment |
|
@krzyk Thanks for review! Please, take a look if it's better now... |
| * @throws IOException If fails | ||
| * @checkstyle ExecutableStatementCountCheck (2 lines) | ||
| */ | ||
| private void copy(final WritableByteChannel target, | ||
| final byte[] boundary) throws IOException { | ||
| final byte[] boundary, | ||
| final ReadableByteChannel body) throws IOException { |
There was a problem hiding this comment.
@dalifreire you can put body in the previous line, and leave only throws in this one
|
@dalifreire one more comment |
|
@krzyk Could you review again? |
|
@krzyk Please, could you take a look if everything is right now? |
|
@dalifreire looks good |
|
@rultor merge pls |
|
@rultor merge |
|
@elenavolokhova review this ticket please, for compliance with our quality rules |
|
@rultor deploy now pls |
|
@davvd Looks good! |
@elenavolokhova thanks a lot :) |
|
@krzyk just added 10 mins to @elenavolokhova (for QA), payment ID is |
Issue #594 - Solving puzzle 558-afc1c081 in
src/main/java/org/takes/rq/RqMultipart.java:131-135