Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaType.java:62-66: MediaType ctor. According to new... #606

Closed
davvd opened this issue Feb 12, 2016 · 17 comments
Closed

MediaType.java:62-66: MediaType ctor. According to new... #606

davvd opened this issue Feb 12, 2016 · 17 comments

Comments

@davvd
Copy link

davvd commented Feb 12, 2016

Puzzle 558-12fc4eff in src/main/java/org/takes/facets/fork/MediaType.java:62-66 has to be resolved: MediaType ctor. According to new qulice version, constructor must contain only variables initialization and other constructor calls. Refactor code according to that rule and remove ConstructorOnlyInitializesOrCallOtherConstructors warning suppression.... The puzzle was created by Maksimenko Vladimir on 7-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 12, 2016

@dalifreire could you please pick this up? This article explains how we work. Any technical questions you may ask right here; The budget of this task is 30 mins. This is exactly how much time will be compensated, when the task is completed. Read about our Definition of Done

@davvd
Copy link
Author

davvd commented Feb 12, 2016

@yegor256 I added milestone 1.0 to this issue, let me know if there has to be something else

@davvd davvd added this to the 1.0 milestone Feb 12, 2016
@dalifreire
Copy link
Contributor

@davvd I sent the away command to @alice before you assign this task for me. Could you assign this task to someone else?

@davvd
Copy link
Author

davvd commented Feb 17, 2016

@davvd I sent the away command to @alice before you assign this task for me. Could you assign this task to someone else?

@dalifreire I deducted 30 points from your rating

@davvd
Copy link
Author

davvd commented Feb 17, 2016

@davvd I sent the away command to @alice before you assign this task for me. Could you assign this task to someone else?

@dalifreire I will try to find someone else

@dalifreire
Copy link
Contributor

@davvd Why?

@dalifreire
Copy link
Contributor

@davvd I think there was a misunderstanding here... as you delayed to answer me, I have finished the task!

@davvd davvd removed the @dalifreire label Feb 17, 2016
@yegor256
Copy link
Owner

@davvd pls assign @dalifreire back to this ticket

@davvd
Copy link
Author

davvd commented Feb 27, 2016

@davvd Why?

@dalifreire @yegor256 will help

@davvd
Copy link
Author

davvd commented Feb 27, 2016

@davvd I think there was a misunderstanding here... as you delayed to answer me, I have finished the task!

@dalifreire @yegor256 please help us here

@davvd
Copy link
Author

davvd commented Feb 27, 2016

@davvd pls assign @dalifreire back to this ticket

@yegor256 OK @dalifreire please proceed, this task is yours

@dalifreire
Copy link
Contributor

@davvd Thanks. PR #616 is merged, can you close the issue and revert my 30 points deducted from my rating?

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 The task is done, thanks all, I am closing it

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@ypshenychka please, review this task for compliance with our quality rules

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Quality is good.

@ypshenychka thanks for the review

@davvd
Copy link
Author

davvd commented Mar 1, 2016

@dalifreire I added 10 mins to @ypshenychka (for QA review) in transaction 79092003; 1 hour sent to your balance (ID 79092023), many thanks! It took zero.; there is a bonus for fast delivery (m=0); +60 added to your rating, current score is: +60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants