Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FkHitRefresh.java:117-121: FkHitRefresh ctor. According to new... #589

Closed
davvd opened this issue Feb 10, 2016 · 20 comments
Closed

FkHitRefresh.java:117-121: FkHitRefresh ctor. According to new... #589

davvd opened this issue Feb 10, 2016 · 20 comments

Comments

@davvd
Copy link

davvd commented Feb 10, 2016

Puzzle 558-b4a12ea6 in src/main/java/org/takes/facets/fork/FkHitRefresh.java:117-121 has to be resolved: FkHitRefresh ctor. According to new qulice version, constructor must contain only variables initialization and other constructor calls. Refactor code according to that rule and remove ConstructorOnlyInitializesOrCallOtherConstructors warning suppression.... The puzzle was created by Maksimenko Vladimir on 7-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@essobedo this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions... 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

@essobedo
Copy link
Contributor

@davvd the PR is ready to be reviewed thx in advance

@davvd
Copy link
Author

davvd commented Feb 11, 2016

@yegor256 attached this issue to milestone "1.0" (let me know if this is wrong)

@davvd davvd added this to the 1.0 milestone Feb 11, 2016
@essobedo
Copy link
Contributor

@davvd The PR has been merged, could you please close the ticket and proceed with the QA. Thank you in advance.

@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

1 similar comment
@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 Closing..

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@elenavolokhova review this ticket please, for compliance with our quality rules

@elenavolokhova
Copy link

@essobedo
According to our quality rules:

Some of ticket messages must mention all pull requests where the problem was actually fixed.

There is no link to related PR in comments. Please fix this issue and follow this rule in your tickets in the future.

@essobedo
Copy link
Contributor

@elenavolokhova link to the PR added thanks for the feedback

@elenavolokhova
Copy link

@davvd Quality is acceptable here.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Quality is acceptable here.

@elenavolokhova thank you, let's try to make it "good" next time

@essobedo
Copy link
Contributor

@davvd everything is ok here could you please proceed?

1 similar comment
@essobedo
Copy link
Contributor

@davvd everything is ok here could you please proceed?

@essobedo
Copy link
Contributor

@davvd the last one please

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@essobedo just added 10 mins to @elenavolokhova (for QA), payment ID is 79023774; paid, thanks, added 30 mins to your account, payment 79023789, 396 hours and 56 mins was spent; +30 added to your rating, at the moment it is: +285

@essobedo
Copy link
Contributor

@davvd thank you

@davvd
Copy link
Author

davvd commented Mar 1, 2016

@davvd everything is ok here could you please proceed?

@essobedo I will, give it some time. we usually pay in 2-3 days after the ticket is closed

@davvd
Copy link
Author

davvd commented Mar 1, 2016

@davvd thank you

@essobedo you are welcome

@essobedo
Copy link
Contributor

essobedo commented Mar 1, 2016

@essobedo I will, give it some time. we usually pay in 2-3 days after the ticket is closed

@davvd thank you for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants