#589: Make the constructors of FkHitRefresh compliant with ConstructorOnlyInitializesOrCallOtherConstructors #593
Conversation
…rOnlyInitializesOrCallOtherConstructors
|
@essobedo Thanks for the pull request, let me find a reviewer.. |
|
@longtimeago review this one, please |
| @@ -172,7 +164,16 @@ private boolean expired() { | |||
| * @throws IOException If fails | |||
| */ | |||
| private void touch() throws IOException { | |||
There was a problem hiding this comment.
@essobedo looks like we don't need this method anymore
There was a problem hiding this comment.
@longtimeago Actually it is still needed as you can see here
There was a problem hiding this comment.
@essobedo can't we pass this.last into private static void touch ?
There was a problem hiding this comment.
@longtimeago as you like
|
@essobedo see one remark above, thanks! |
|
@essobedo much better now :) |
|
@rultor merge |
@longtimeago Thanks for your request. @yegor256 Please confirm this. |
|
@longtimeago thank you for the review |
|
@essobedo you are welcome :) |
|
@yegor256 please confirm |
|
@yegor256 please confirm |
|
@yegor256 This PR is waiting for a confirmation for more than a week now, so could you please do something about it? confirm it or reject it but please do something about it. |
| * @return The file to touch | ||
| * @throws IOException If fails | ||
| */ | ||
| private static File createFileToTouch() throws IOException { |
There was a problem hiding this comment.
|
@essobedo one comment above |
|
@yegor256 thank you for the review and the remark. Please have a look to the new version of the PR. Thank you in advance. |
|
@yegor256 please review the PR |
1 similar comment
|
@yegor256 please review the PR |
|
@rultor try to merge |
|
@yegor256 thx |
|
@elenavolokhova please, help us to evaluate quality here, as per par.24 |
|
@rultor please deploy |
|
@longtimeago
Only one issue was found during review. |
|
@elenavolokhova I confirm |
|
@davvd Quality is acceptable here. |
@elenavolokhova thanks for the QA review, we'll work better next time |
|
@longtimeago paied 10 mins to @elenavolokhova for QA review (payment ID is |
Fix for #589
The goal of this PR is to make the class FkHitRefresh compliant with the rule ConstructorOnlyInitializesOrCallOtherConstructors by delegating the construction of the file to touch to a private static method.